<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Committed:<div><br></div><div><a href="http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20130916/009544.html">http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20130916/009544.html</a></div><div><br></div><div>Thanks for your patch!</div><div><br></div><div><div>
<div>Sean</div>
</div>
<br><div><div>On Sep 15, 2013, at 11:17 PM, Sean Callanan <<a href="mailto:scallanan@apple.com">scallanan@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="content-type" content="text/html; charset=utf-8"><div dir="auto"><div>Félix,</div><div><br></div><div>thanks for your patch! It does look good, let me give it a quick test tomorrow and I'll be happy to commit it.</div><div><br></div><div>Sean<br><br>Sent from my iPad</div><div><br>On Sep 15, 2013, at 10:36 AM, Félix Cloutier <<a href="mailto:felixcca@yahoo.ca">felixcca@yahoo.ca</a>> wrote:<br><br></div><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1">I sent this about a week ago, but I <a href="http://lists.cs.uiuc.edu/pipermail/lldb-dev/2013-September/002373.html">did it so unceremoniously</a> that it has probably fallen under the radar.<div><br></div><div>This patch fixes an issue where expression results are saved in host byte order rather than in target byte order. It only modifies source/Expression/IRInterpreter.cpp.</div><div><br></div><div>DISCLAIMER: when I tried to run the tests, I got this message:</div><div><br></div><div></div><blockquote type="cite">This script requires lldb.py to be in either /Users/felix/Projets/OpenSource/lldb/build/Debug/LLDB.framework/Resources/Python, /Users/felix/Projets/OpenSource/lldb/build/Release/LLDB.framework/Resources/Python, or /Users/felix/Projets/OpenSource/lldb/build/BuildAndIntegration/LLDB.framework/Resources/Python</blockquote><div><br></div><div>So I naively tested `int $x = 0x01020304;` on my target with a different byte order and on a native program, and both cases work. I also tried `int $x[2] = {0x0102, 0x0203};` and it <b>does not</b> work (it creates a zeroed array of 2 elements), but it came to my attention that it also doesn't work with the release of lldb that ships with Xcode, so I don't think it's due to this change.</div><div><br></div><div>Félix</div><div><br></div><div></div></blockquote><blockquote type="cite"><FixExpressionEndianness.diff></blockquote><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div></div></blockquote></div></blockquote></div><br></div></body></html>