<div dir="ltr">Thanks Ashok for committing.<div><br></div><div><br></div><div class="gmail_extra"><div class="gmail_quote">On Fri, Jul 12, 2013 at 2:35 PM, Thirumurthi, Ashok <span dir="ltr"><<a href="mailto:ashok.thirumurthi@intel.com" target="_blank">ashok.thirumurthi@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Thanks Samuel, I know this will be much appreciated!<br>
<br>
The only change I had to make was the test on ProcessElfCore.cpp:298, which needs to be a null test rather than a comparison with false to build using clang trunk. Works as advertised and introduces no regressions, so I fired r186207.<br>
<br>
I noticed that you skipped the call to ReadFPR that reads AVX registers in the constructor of RegisterContext_x86_64. I noticed that register read -a includes all expected registers on an SSE machine. Did you run into issues with the call during construction? Should we be moving to cupid to query this functionality, for instance?<br>
</blockquote><div><br></div><div>Yes - I skipped ReadFPR() because it was accessing AVX registers(valgrind helped me to find that).</div><div>fpregset is never used in RegisterContextCoreLinux_x86_64, so "register read -a" might not have valid value for floating point registers.</div>
<div>Adding floating point support should be easy. I will do that once I get some time.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Also, do let us know if you need any help adding tests. Cheers,<br></blockquote><div><br></div><div>Today I try to run test-suite and having trouble with it. 'ninja check-lldb' causing lot of failures, are these failures expected or am I missing some configuration?</div>
<div>(Ubuntu 13.04, Python 2.7.4, gcc 4.7.3)<br></div><div><br></div><div><div>$ ninja check-lldb</div><div>....</div><div><div>Ran 262 tests.</div><div>Failing Tests (76)</div><div>FAIL: LLDB (suite) :: TestCallStdStringFunction.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div>
<div>FAIL: LLDB (suite) :: TestFormatters.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div><div>FAIL: LLDB (suite) :: Test11588.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div>
<div>FAIL: LLDB (suite) :: TestBitfields.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div><div>FAIL: LLDB (suite) :: TestAnonymous.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div>
<div>FAIL: LLDB (suite) :: TestVirtual.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div><div>FAIL: LLDB (suite) :: TestCPPExceptionBreakpoints.py (Linux <a href="http://jacobs-lnx.eng.vmware.com">jacobs-lnx.eng.vmware.com</a> 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:07 UTC 2013 x86_64 x86_64)</div>
</div></div><div>.....</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
- Ashok<br>
<div class=""><div class="h5"><br>
<br>
-----Original Message-----<br>
From: <a href="mailto:lldb-dev-bounces@cs.uiuc.edu">lldb-dev-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:lldb-dev-bounces@cs.uiuc.edu">lldb-dev-bounces@cs.uiuc.edu</a>] On Behalf Of Greg Clayton<br>
Sent: Thursday, July 11, 2013 8:41 PM<br>
To: Samuel Jacob<br>
Cc: lldb-dev<br>
Subject: Re: [lldb-dev] Patch for review: elf-core dump plugin<br>
<br>
Very nice, looks great. Check in when you get the chance.<br>
<br>
Greg<br>
<br>
On Jul 11, 2013, at 5:24 PM, Samuel Jacob <<a href="mailto:samueldotj@gmail.com">samueldotj@gmail.com</a>> wrote:<br>
<br>
> Please review the attached patch.<br>
><br>
> Ashok, thanks for the pre-review comments, please provide if you have more comments.<br>
> I am planning to add test cases after this get patch get committed.<br>
><br>
> Compiles and works fine on Ubuntu 13.04.<br>
> Here is the sample output:<br>
><br>
> $lldb a.out -c core<br>
> Core file '/usr/build/llvm/core' (x86_64) was loaded.<br>
> Process 0 stopped<br>
> * thread #1: tid = 0x0000, 0x0000000000400570 a.out`recursive_function(i=10) + 44 at test.c:60, name = 'a.out, stop reason = signal SIGSEGV<br>
> frame #0: 0x0000000000400570 a.out`recursive_function(i=10) + 44 at test.c:60<br>
> 57 recursive_function(i+1);<br>
> 58 } else {<br>
> 59 char *crash=0;<br>
> -> 60 *crash = 0;<br>
> 61 }<br>
> 62 }<br>
> 63<br>
><br>
> (lldb) bt<br>
> * thread #1: tid = 0x0000, 0x0000000000400570 a.out`recursive_function(i=10) + 44 at test.c:60, name = 'a.out, stop reason = signal SIGSEGV<br>
> frame #0: 0x0000000000400570 a.out`recursive_function(i=10) + 44 at test.c:60<br>
> frame #1: 0x0000000000400562 a.out`recursive_function(i=9) + 30 at test.c:57<br>
> frame #2: 0x0000000000400562 a.out`recursive_function(i=8) + 30 at test.c:57<br>
> frame #3: 0x0000000000400562 a.out`recursive_function(i=7) + 30 at test.c:57<br>
> frame #4: 0x0000000000400562 a.out`recursive_function(i=6) + 30 at test.c:57<br>
> frame #5: 0x0000000000400562 a.out`recursive_function(i=5) + 30 at test.c:57<br>
> frame #6: 0x0000000000400562 a.out`recursive_function(i=4) + 30 at test.c:57<br>
> frame #7: 0x0000000000400562 a.out`recursive_function(i=3) + 30 at test.c:57<br>
> frame #8: 0x0000000000400562 a.out`recursive_function(i=2) + 30 at test.c:57<br>
> frame #9: 0x0000000000400562 a.out`recursive_function(i=1) + 30 at test.c:57<br>
> frame #10: 0x0000000000400562 a.out`recursive_function(i=0) + 30 at test.c:57<br>
> frame #11: 0x00000000004005a7 a.out`static_function + 50 at test.c:68<br>
> frame #12: 0x00000000004005b5 a.out`call_me6 + 14 at test.c:77<br>
> frame #13: 0x00000000004005c3 a.out`call_me5 + 14 at test.c:80<br>
> frame #14: 0x00000000004005d3 a.out`call_me4 + 14 at test.c:81<br>
> frame #15: 0x00000000004005e3 a.out`call_me3 + 14 at test.c:82<br>
> frame #16: 0x00000000004005f3 a.out`call_me2 + 14 at test.c:83<br>
> frame #17: 0x0000000000400603 a.out`call_me1 + 14 at test.c:84<br>
> frame #18: 0x0000000000400613 a.out`call_me + 14 at test.c:89<br>
> frame #19: 0x0000000000400670 a.out`test_func(para1=0x00000000020a1010) + 91 at test.c:108<br>
> frame #20: 0x000000000040070b a.out`main(argc=1, argv=0x00007fffba029498) + 145 at test.c:128<br>
><br>
> Thanks<br>
> Samuel<br>
> <lldb_elfcore.diff>_______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
</div></div></blockquote></div><br></div></div>