<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi all,<div><div>hopefully the third time is the charm :)</div><div><br></div><div><blockquote type="cite"><div>The only quibble I have is that you do a bunch of path manipulation by hand here that should be done through FileSpec. </div></blockquote><br><blockquote type="cite"><div>Also, instead of pulling off the .pyc or .py extension by hand it would be good to add this functionality to FileSpec, since that is also generally useful.</div></blockquote></div><div><br></div><div>I have modified the implementation following Jim's advice, and now I use FileSpec directly. I have also added a method named GetFilenameExtension() to said class.</div><div><br></div><div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>As to the test case, no, it does not belong in the python_api subdirectory. You can create a</div><div>functionalities/command_script subdir to house the import dir.</div></div></blockquote></div><div><br></div><div>It looks like you had already created functionalities/command_script. I have created an import subdirectory there and moved my test case files there.</div><div><br></div><div>Thanks for the feedback on this patch.</div><div><br></div><div>Sincerely,</div><div><div apple-content-edited="true"></div></div></div></body></html>