<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Filipe,<div><br></div><div>Thanks for the patches. The ifdef and uninitialized patches have been applied.</div><div>As to the get-first-thread patch, we're considering to modify the GetSelectedThread() method impl</div><div>so that it returns the 0th thread if there is no selected thread.</div><div><br></div><div>Thanks again!</div><div>Johnny</div><div><br><div><div>On Aug 24, 2011, at 6:23 PM, Filipe Cabecinhas wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi,<div><br></div><div>I sent some small fixes to the list, but I don't know if anyone saw them, since they got mixed with some questions I had.</div><div><br></div><div>One fixes debug code that usually gets ifdeffed out of compilation.</div>
<div>Another one initializes a uint64_t variable that would get the highest 32-bits zeroed out when executing a 32-bit target, resulting in possibly wrong addresses when disassembling code.</div><div>The "get-first-thread-if-no-selected-thread" patch makes CommandObjectThreadStepWithTypeAndScope::Execute behave like what was told to be the desired behaviour: If there is no selected thread, the first thread is selected (<a href="http://lists.cs.uiuc.edu/pipermail/lldb-dev/2011-July/000522.html">http://lists.cs.uiuc.edu/pipermail/lldb-dev/2011-July/000522.html</a> ).</div>
<div><br></div><div>Regards,</div><div><br></div><div> Filipe</div><div><br></div>
<span><fix-ifdeffed-code-stackframelist.patch></span><span><get-first-thread-if-no-selected-thread.patch></span><span><uninitialized-uint64.patch></span>_______________________________________________<br>lldb-dev mailing list<br><a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev<br></blockquote></div><br></div></body></html>