Thank you for fixing it up!<div><br></div><div>Since we're on the subject of missing standard library methods, I figured now would be a good time to bring up this patch as well. I don't have a std::bitset::to_string() on Leopard either.</div>
<div><br></div><div>The implementation was pulled from <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/bitset?view=markup">http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/bitset?view=markup</a></div>
<div><br></div><div>-Bill</div><div>
<br></div><div><div>Index: source/Core/DataExtractor.cpp</div><div>===================================================================</div><div>--- source/Core/DataExtractor.cpp<span style="white-space:pre-wrap"> </span>(revision 108959)</div>
<div>+++ source/Core/DataExtractor.cpp<span style="white-space:pre-wrap"> </span>(working copy)</div><div>@@ -1197,7 +1197,13 @@</div><div> case eFormatBinary:</div><div> {</div><div>
uint64_t uval64 = GetMaxU64Bitfield(&offset, item_byte_size, item_bit_size, item_bit_offset);</div><div>- std::string binary_value(std::bitset<64>(uval64).to_string());</div><div>
+</div><div>+ std::string binary_value(64, '0');</div><div>+ std::bitset<64> bits(uval64);</div><div>+ for (size_t i = 0; i < 64; ++i)</div><div>+ if (bits[i])</div>
<div>+ binary_value[64 - 1 - i] = '1';</div><div>+</div><div> if (item_bit_size > 0)</div><div> s->Printf("0b%s", binary_value.c_str() + 64 - item_bit_size);</div>
<div> else if (item_byte_size > 0 && item_byte_size <= 8)</div></div><div><br></div><div><br><br><div class="gmail_quote">On Tue, Jul 20, 2010 at 5:55 PM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Modified version of this patch was submitted with r108957.<br>
<br>
Thanks for catching this William.<br>
<br>
Greg Clayton<br>
<div><div></div><div><br>
On Jul 20, 2010, at 2:21 PM, William Lynch wrote:<br>
<br>
> Hello,<br>
><br>
> I've attached a fairly large patch (touches 21 files).<br>
><br>
> The point of this patch is to remove all calls to std::vector::data() with &std::vector::front(). Apparently on CentOS 5 and Leopard, that method is not part of std::vector.<br>
><br>
> As a side note, should I be submitting these patches to this list or to lldb-commits?<br>
><br>
> Thanks!<br>
</div></div>> <foo.patch>_______________________________________________<br>
<div><div></div><div>> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br>
</div></div></blockquote></div><br></div>