[lldb-dev] Signedness of scalars built from APInt(s)

[Davide Italiano via lldb-dev]

On Fri, Jan 4, 2019 at 3:54 PM Zachary Turner <zturner at google.com> wrote:
>
> It seems like we have 3 uses of this constructor in LLDB.
>
> IRInterpreter.cpp: Constructs a Scalar for an llvm::Constant.
> IRForTarget.cpp:  Constructs a Scalar for an llvm::Constant.
> ClangASTContext.cpp: bitcasts an APFloat to an APInt.
>
> The first two we should just treat constants in LLVM IR as signed, so we could construct an APSInt at the call-sites with signed=true.
>

OK, I think there might be subtleties we're missing right now but the
best way is just try and see what happens.
I'll send patches early next week.

--
Davide