[lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
Timothee Cour via lldb-dev
lldb-dev at lists.llvm.org
Fri Mar 9 00:44:06 PST 2018
I've registered to
http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits and sent
my patch via that email to lldb-commits at lists.llvm.org but doesn't
appear yet on http://lists.llvm.org/pipermail/lldb-commits/ ; how long
does it take for
Still not sure why github PR's can't be accepted to remove all this
friction for outside developpers.
On Tue, Feb 27, 2018 at 9:25 AM, Jim Ingham <jingham at apple.com> wrote:
> I only briefly scanned the patch, but I'm not sure treating D as another mangling variant of C++ is the best model - I think it will be easier if we gather all the separate language features up in the individual languages. You might have a look at the swift-enabled lldb (https://github.com/apple/swift-lldb/) to see how it is handled there. That's a little weak because we iterate over supported languages by hand. When there were a few that wasn't an issue, but as we pick up more languages, we should introduce a "do over supported languages" feature which would clean up the logic there.
>> On Feb 26, 2018, at 9:01 PM, Timothee Cour via lldb-dev <lldb-dev at lists.llvm.org> wrote:
>> it would be *really* nice if llvm or lldb accepted industry standard
>> github PR's, at least as an option. Would make contributing so much
>> easier for outsiders
>> lldb-dev mailing list
>> lldb-dev at lists.llvm.org
More information about the lldb-dev