[lldb-dev] Handling callable addresses

Jim Ingham via lldb-dev lldb-dev at lists.llvm.org
Thu Jun 21 13:58:03 PDT 2018

It's actually a little lame that we have a switch over architectures in generic Target code.  This should be gotten from the architecture plugin.  GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific code in Target.cpp, which seems really wrong to me.

Not really answering your question except formally none of this code should be in Target.cpp...


> On Jun 21, 2018, at 11:52 AM, Tatyana Krasnukha via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> Hi,
> It seems Target::GetCallableLoadAddress does equivalent things for arm/thumb and for mipses, just written in different forms. May I join these cases together?
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

More information about the lldb-dev mailing list