[lldb-dev] purpose of ProcessGDBRemote::m_flags

Greg Clayton via lldb-dev lldb-dev at lists.llvm.org
Fri Nov 3 11:37:13 PDT 2017


If this isn't used, then this should be removed. Anything dynamic settings that are retrieved need to be abstracted into this class. There isn't a need for an extra plug-in as ProcessGDBRemote handles all variants of GDB remote servers and it should encapsulate all that is needed to use any GDB server.

> On Nov 3, 2017, at 7:27 AM, Tatyana Krasnukha via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> 
> Hello,
>  
> I have questions about ProcessGDBRemote::m_flags member. Seems like it is never used. What is the purpose of it and what is the reason to do accessors protected, even constant getter? And other question: isn’t it better to move this member to new plugin Architecture to be able to store dynamic architecture features (read from target’s configuration registers, for example)?
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org <mailto:lldb-dev at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20171103/a9f3ed91/attachment-0001.html>


More information about the lldb-dev mailing list