[lldb-dev] LLDB REFORMATTING IN PROGRESS

Zachary Turner via lldb-dev lldb-dev at lists.llvm.org
Tue Sep 6 14:21:10 PDT 2016


I think it goes without saying, but henceforth, no changes should be landed
without first passing them through clang-format.  Personally, I will be
reverting any I see that don't conform.  But I can't promise to catch all
of them.

On Tue, Sep 6, 2016 at 2:17 PM Kate Stone via lldb-dev <
lldb-dev at lists.llvm.org> wrote:

> The storm of commit messages might be a subtle clue, but here it is
> officially: the reformatting is complete and I’ve verified that no tests
> regressed locally in our macOS suite.  Please begin any validation process
> you’ve signed up for on another platform, and if changes are necessary go
> ahead and land them individually.
>
> From the commit message:
>
> *** This commit represents a complete reformatting of the LLDB source code
> *** to conform to clang-format’s LLVM style.  This kind of mass change has
> *** two obvious implications:
>
> Firstly, merging this particular commit into a downstream fork may be a
> huge
> effort.  Alternatively, it may be worth merging all changes up to this
> commit,
> performing the same reformatting operation locally, and then discarding the
> merge for this particular commit.  The commands used to accomplish this
> reformatting were as follows (with current working directory as the root of
> the repository):
>
>     find . \( -iname "*.c" -or -iname "*.cpp" -or -iname "*.h" -or -iname
> "*.mm" \) -exec clang-format -i {} +
>     find . -iname "*.py" -exec autopep8 --in-place --aggressive
> --aggressive {} + ;
>
> The version of clang-format used was 3.9.0, and autopep8 was 1.2.4.
>
> Secondly, “blame” style tools will generally point to this commit instead
> of
> a meaningful prior commit.  There are alternatives available that will
> attempt
> to look through this change and find the appropriate prior commit.  YMMV.
>
>
> Thanks for your collective support and assistance in preparing for this
> change.
>
> Kate Stone k8stone at apple.com
>  Xcode Low Level Tools
>
> On Sep 6, 2016, at 10:24 AM, Kate Stone <k8stone at apple.com> wrote:
>
> As has been discussed over the past few weeks the reformatting of the LLDB
> code base will take place shortly, followed by validation before committing
> these changes.  Please suspend all commit activity.  Any intervening
> commits *will be reverted* until the all-clear is given.
>
> Kate Stone k8stone at apple.com
>  Xcode Low Level Tools
>
>
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20160906/900c4fbc/attachment-0001.html>


More information about the lldb-dev mailing list