[lldb-dev] Bug in CommandObjectThreadUntil

Jim Ingham via lldb-dev lldb-dev at lists.llvm.org
Fri Nov 18 14:16:33 PST 2016


Obviously a bug.  Fixed in r287386.

Jim

> On Nov 18, 2016, at 11:47 AM, Zachary Turner via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> 
> CommandObjectThreadUntil::DoExecute() has the following code:
> 
>         for (size_t i = 0; i < num_args; i++) {
>           uint32_t line_number;
>           line_number = StringConvert::ToUInt32(command.GetArgumentAtIndex(0),
>                                                 UINT32_MAX);
>           if (line_number == UINT32_MAX) {
>             result.AppendErrorWithFormat("invalid line number: '%s'.\n",
>                                          command.GetArgumentAtIndex(0));
>             result.SetStatus(eReturnStatusFailed);
>             return false;
>           } else
>             line_numbers.push_back(line_number);
>         }
> 
> 1) It looks to me like this is supposed to be GetArgumentAtIndex(i) instead of GetArgumentAtIndex(0).  Is this in fact a bug?
> 
> 2) The ability for this command to take multiple line numbers is not documented.  Should it be?
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20161118/21070aa4/attachment.html>


More information about the lldb-dev mailing list