[lldb-dev] LLDB Evolution
Kate Stone via lldb-dev
lldb-dev at lists.llvm.org
Thu Aug 11 10:55:18 PDT 2016
100% agreed, though we do want to avoid multiple formatting passes over time if at all possible. Having exceptions to the comment formatting rules for the entire test suite subtree is acceptable – presuming we aren’t planning to come back and do another pass where we revisit that decision in the near future.
Kate Stone k8stone at apple.com <mailto:k8stone at apple.com>
Xcode Low Level Tools
> On Aug 11, 2016, at 9:57 AM, Chris Lattner via lldb-dev <lldb-dev at lists.llvm.org> wrote:
>> On Aug 11, 2016, at 7:41 AM, Pavel Labath <labath at google.com> wrote:
>> I just committed another header cleanup commit, which makes lldb
>> clang-format-immune ( = it still compiles after a full reformat) on
>> linux. Other OS's are still likely to have some missed dependencies.
>> However, when I tried running the test suite I got about 150 failures.
>> Based on a sample of the errors, it looks like the problem is that
>> clang format messes up the "// Place breakpoint here" annotations we
>> use in the tests.
>> Therefore, I propose to apply the clang-format to the lldb source code
>> only as a first step. After that, as a second step, we can go through
>> the tests and fix them up so that the comment markers are where we
>> expect them to be.
> Personally, I think that reformatting is most valuable for the debugger code itself. The testsuite following standards seems like a separable issue, and much lower priority.
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-dev