[lldb-dev] [Lldb-commits] [lldb] r226234 - Add Socket::Get[Remote/Local]IpAddress and unit tests

Zachary Turner zturner at google.com
Fri Jan 16 12:48:08 PST 2015


I will sync to ToT and fix up remaining windows issues.

On Fri Jan 16 2015 at 11:23:10 AM Vince Harron <vharron at google.com> wrote:

> I did my best.  I'm still unable to get Windows building.
>
> http://reviews.llvm.org/rL226301
>
>
> On Fri, Jan 16, 2015 at 9:47 AM, Vince Harron <vharron at google.com> wrote:
>
>> Will fix ASAP
>> On Jan 16, 2015 6:59 AM, "Carlo Kok" <ck at remobjects.com> wrote:
>>
>>>
>>>
>>> Vince Harron schreef op 1/16/2015 om 1:47 AM:
>>>
>>>> Author: vharron
>>>> Date: Thu Jan 15 18:47:08 2015
>>>> New Revision: 226234
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=226234&view=rev
>>>> Log:
>>>> Add Socket::Get[Remote/Local]IpAddress and unit tests
>>>>
>>>> Differential Revision: http://reviews.llvm.org/D6917
>>>>
>>>>
>>>> Added:
>>>>      lldb/trunk/gtest/unittest/Host/
>>>>      lldb/trunk/gtest/unittest/Host/Makefile
>>>>      lldb/trunk/gtest/unittest/Host/SocketAddressTest.cpp
>>>>      lldb/trunk/gtest/unittest/Host/SocketTest.cpp
>>>>      lldb/trunk/gtest/unittest/Host/SocketTestMock.cpp
>>>> Modified:
>>>>      lldb/trunk/gtest/gtest.xcodeproj/project.pbxproj
>>>>      lldb/trunk/include/lldb/Host/Socket.h
>>>>      lldb/trunk/include/lldb/Host/SocketAddress.h
>>>>      lldb/trunk/source/Host/common/Socket.cpp
>>>>      lldb/trunk/source/Host/common/SocketAddress.cpp
>>>>      lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
>>>>
>>>
>>> Looks like the open { after the case in:
>>> lldb/trunk/source/Host/common/SocketAddress.cpp line 42 is not properly
>>> closed.
>>>
>>> --
>>> Carlo Kok
>>> RemObjects Software
>>>
>>
>
>
> --
>
> Vince Harron | Technical Lead Manager | vharron at google.com | 858-442-0868
>  _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20150116/550bafdc/attachment.html>


More information about the lldb-dev mailing list