[lldb-dev] lldb TOT breaks against TOT clang SourceManager API change

[Todd Fiala]

(Fix went in at r209303).


On Wed, May 21, 2014 at 9:02 AM, Todd Fiala <tfiala at google.com> wrote:

> Looks like Rafael beat me to it.  Thanks!
>
>
> On Wed, May 21, 2014 at 8:22 AM, Todd Fiala <tfiala at google.com> wrote:
>
>> That's this clang svn change: r209266 (truncated that line from my
>> message above):
>>
>>     git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@20926691177308-0d34-0410-b5e6-96231b3b80d8
>>
>>
>>
>> On Wed, May 21, 2014 at 8:21 AM, Todd Fiala <tfiala at google.com> wrote:
>>
>>> Looks like this change requires a fix in lldb:
>>>
>>> commit 16b97825c5c0fc1aa5da7caa355e611695325370
>>> Author: Alp Toker <alp at nuanti.com>
>>> Date:   Wed May 21 01:12:41 2014 +0000
>>>
>>>     SourceManager: Use setMainFileID() consistently
>>>
>>>     Eliminate createMainFileID() / createMainFileIDForMemBuffer() utility
>>>     functions. These didn't add much convenience and conflated two
>>> distinct
>>>     operations.
>>>
>>>     This change makes things easier to follow by providing a consistent
>>> interface
>>>     and getting rid of a bunch of cast-to-voids.
>>>
>>> I'll start looking at this in a few moments.  If somebody is already
>>> working on a fix, let me know.
>>>
>>> --
>>>  Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>>>
>>
>>
>>
>> --
>> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>>
>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140521/5d4b4224/attachment.html>