[lldb-dev] [PATCH] Minor lldb_private::ModuleList fixes

Piotr Rak piotr.rak at gmail.com
Mon Mar 24 11:36:31 PDT 2014


2014-03-24 17:58 GMT+01:00 Greg Clayton <gclayton at apple.com>:

> Note that std::once can be used to enforce "run once" and we don't have to
> worry about each platform (like we would have to if we used pthread_once).
> Modified version submitted with:
> Author: gclayton
> Date: Mon Mar 24 11:50:33 2014
> New Revision: 204622
> URL: http://llvm.org/viewvc/llvm-project?rev=204622&view=rev
> Log:
> Modified patch from Piotr Rak that makes GetSharedModuleList() more thread
> safe and also fixed a missed member initialization on the copy contractor
> and also makes the assignment operator safer.
> Modified:
>    lldb/trunk/source/Core/ModuleList.cpp

Thanks, that's great we can use that, I have not seen any use of std::once,
and that's why I was avoiding it.
Like I avoided ranged version of for before I have noticed we already use
I've seen comments about lack of atomic for Windows in debug shared_ptr
implementation, and also we wrap things like mutex, condition variable,

For future:
Are there any clear guidelines what feature set form C++11 is safe to use?
Or we shouldn't limit ourselves until someone starts screaming out laud?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140324/14ca35c0/attachment.html>

More information about the lldb-dev mailing list