[lldb-dev] [patch] Remove inclusion of pthread.h for mingw
Hafiz_Abid at mentor.com
Tue Mar 11 04:33:59 PDT 2014
Thanks Greg for a quick review. Committed.
I saw a some failure on freebsd builtbot after this commit. It seems that some clang test is failing.
It does not seem related to this commit but please let me know if this caused any breakage.
> -----Original Message-----
> From: Greg Clayton [mailto:gclayton at apple.com]
> Sent: 10 March 2014 23:20
> To: Abid, Hafiz
> Cc: lldb-dev at cs.uiuc.edu
> Subject: Re: [lldb-dev] [patch] Remove inclusion of pthread.h for mingw
> Looks fine.
> On Mar 10, 2014, at 3:57 PM, Abid, Hafiz <Hafiz_Abid at mentor.com> wrote:
> > Hi,
> > This patch removes a check that was put for mingw quite some time ago
> perhaps to get the declaration of timespec. But it does not seem valid to me
> and it relies on having pthread.h which is generally not available for mingw.
> We are now providing a definition for struct timespce in win32.h which can
> be used for mingw case too. I will apply the attached patch if there are no
> > Thanks,
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
More information about the lldb-dev