[lldb-dev] Config.h

jingham at apple.com jingham at apple.com
Thu Jul 3 12:35:41 PDT 2014


This seems a little backward to me.  We should be encouraging all the generic code in lldb to have no host dependencies unless they are absolutely necessary, shouldn't we?  Making all .cpp files include a host specific header file seems going counter to this aim.

Jim


> On Jul 2, 2014, at 10:04 PM, Zachary Turner <zturner at google.com> wrote:
> 
> It would be useful if there were a header file that were always included in every CPP file before any other header file, that would initialize any platform-specific defines and whatnot.  We already have a header file that seems to serve exactly this purpose, but it just isn't always included.  It's lldb/Host/Config.h
> 
> Doing a single pass over every file and manually including this would be a lot of work, but can we make it a policy going forward that a) this file will always be included first, in every newly created cpp file, and b) When touching files, try to remember to add this include at the top?
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev




More information about the lldb-dev mailing list