[lldb-dev] Submitting a patch
tfiala at google.com
Sat Jan 18 00:16:03 PST 2014
I was able to build it with the following:
../llvm/configure --enable-cxx11 --prefix=`pwd`/../install
It built fine. I did try to run the tests with this:
make -C tools/lldb/test
but I hit some issues that I suspect are purely my environment not setup
totally right on my MacBook Pro.
Since I got it to built, I checked it in here:
tfiala-macbookpro:lldb tfiala$ svn commit
Transmitting file data ...............
Committed revision 199543.
Thanks for the patch, Keno!
On Fri, Jan 17, 2014 at 11:15 PM, Todd Fiala <tfiala at google.com> wrote:
> Hi Keno,
> I'll see if I can download and get it to build here on my MBP tonight. If
> I can get it to build, I'll check it in.
> On Fri, Jan 17, 2014 at 5:21 PM, Greg Clayton <gclayton at apple.com> wrote:
>> I have to head out tonight, but I will see if I can get this is soon for
>> On Jan 17, 2014, at 5:18 PM, Keno Fischer <kfischer at college.harvard.edu>
>> > I don't have commit access.
>> > On Fri, Jan 17, 2014 at 8:14 PM, Greg Clayton <gclayton at apple.com>
>> > Sorry for the delay. Looks good! Please commit when possible.
>> > On Jan 17, 2014, at 4:46 PM, Keno Fischer <kfischer at college.harvard.edu>
>> > > Hi,
>> > >
>> > > What is the official procedure for submitting a patch?
>> > > A couple weeks ago I put a patch on Phabricator and had it sent
>> > > the usual email to to lldb-commits, however since I haven't
>> > > heard anything back, I gather I did something wrong. The
>> > > patch in question is: http://llvm-reviews.chandlerc.com/D2476
>> > > Please let me know what to do and I'll resubmit it the
>> > > proper way.
>> > >
>> > > Thanks,
>> > > Keno
>> > > _______________________________________________
>> > > lldb-dev mailing list
>> > > lldb-dev at cs.uiuc.edu
>> > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu
> Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-dev