[lldb-dev] Submitting a patch

[Todd Fiala]

I was able to build it with the following:

mkdir build
cd build
../llvm/configure --enable-cxx11 --prefix=`pwd`/../install
make -j8

It built fine.  I did try to run the tests with this:

make -C tools/lldb/test

but I hit some issues that I suspect are purely my environment not setup
totally right on my MacBook Pro.

Since I got it to built, I checked it in here:

tfiala-macbookpro:lldb tfiala$ svn commit
Sending        lib/Makefile
Sending        scripts/generate-vers.pl
Sending        source/CMakeLists.txt
Sending        source/Host/common/Host.cpp
Sending        source/Makefile
Sending        source/Plugins/Makefile
Adding         source/Plugins/SystemRuntime/MacOSX/Makefile
Sending        tools/Makefile
Adding         tools/debugserver/Makefile
Adding         tools/debugserver/scripts/Makefile
Sending        tools/debugserver/scripts/dbgnub-config.pl
Adding         tools/debugserver/source/MacOSX/Makefile
Adding         tools/debugserver/source/MacOSX/i386/Makefile
Adding         tools/debugserver/source/MacOSX/x86_64/Makefile
Adding         tools/debugserver/source/Makefile
Transmitting file data ...............
Committed revision 199543.

Thanks for the patch, Keno!

Sincerely,
Todd Fiala


On Fri, Jan 17, 2014 at 11:15 PM, Todd Fiala <tfiala at google.com> wrote:

> Hi Keno,
>
> I'll see if I can download and get it to build here on my MBP tonight.  If
> I can get it to build, I'll check it in.
>
> Thanks!
>
> -Todd
>
>
> On Fri, Jan 17, 2014 at 5:21 PM, Greg Clayton <gclayton at apple.com> wrote:
>
>> I have to head out tonight, but I will see if I can get this is soon for
>> you.
>>
>> Greg
>>
>> On Jan 17, 2014, at 5:18 PM, Keno Fischer <kfischer at college.harvard.edu>
>> wrote:
>>
>> > I don't have commit access.
>> >
>> >
>> > On Fri, Jan 17, 2014 at 8:14 PM, Greg Clayton <gclayton at apple.com>
>> wrote:
>> > Sorry for the delay. Looks good! Please commit when possible.
>> >
>> > On Jan 17, 2014, at 4:46 PM, Keno Fischer <kfischer at college.harvard.edu>
>> wrote:
>> >
>> > > Hi,
>> > >
>> > > What is the official procedure for submitting a patch?
>> > > A couple weeks ago I put a patch on Phabricator and had it sent
>> > > the usual email to to lldb-commits, however since I haven't
>> > > heard anything back, I gather I did something wrong. The
>> > > patch in question is: http://llvm-reviews.chandlerc.com/D2476
>> > > Please let me know what to do and I'll resubmit it the
>> > > proper way.
>> > >
>> > > Thanks,
>> > > Keno
>> > > _______________________________________________
>> > > lldb-dev mailing list
>> > > lldb-dev at cs.uiuc.edu
>> > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>> >
>> >
>>
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>>
>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140118/b4dc5d3f/attachment.html>