[lldb-dev] [PATCH] Recent change to clang header breaks lldb

Todd Fiala tfiala at google.com
Mon Jan 6 12:31:19 PST 2014


Verified locally and submitted.

Sending        source/Symbol/ClangASTType.cpp
Transmitting file data .
Committed revision 198635.



On Mon, Jan 6, 2014 at 11:46 AM, Greg Clayton <gclayton at apple.com> wrote:

> Looks good.
>
> On Jan 6, 2014, at 11:18 AM, Steve Pucci <spucci at google.com> wrote:
>
> > A parameter to a clang method was removed from a call made by lldb (the
> value is determined from the context now).  A fix is attached; can someone
> please review?
> >
> > Thanks,
> >    Steve
> >
> > diff --git a/source/Symbol/ClangASTType.cpp
> b/source/Symbol/ClangASTType.cpp
> > index 0dfabcc..84a04d4 100644
> > --- a/source/Symbol/ClangASTType.cpp
> > +++ b/source/Symbol/ClangASTType.cpp
> > @@ -1134,7 +1134,7 @@ ClangASTType::GetTypeName () const
> >          if (typedef_type)
> >          {
> >              const TypedefNameDecl *typedef_decl =
> typedef_type->getDecl();
> > -            type_name =
> typedef_decl->getQualifiedNameAsString(printing_policy);
> > +            type_name = typedef_decl->getQualifiedNameAsString();
> >          }
> >          else
> >          {
> >
> > _______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com |
650-943-3180<+1-650-943-3180>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140106/b87a0e8d/attachment.html>


More information about the lldb-dev mailing list