[lldb-dev] Linux build errors

[Jason Molenda]

Thanks David, Ed, Michael.  I committed the simple fix for now - it's probably best for Sean to decide about not using the dwarf namespace in this file.

On Oct 21, 2013, at 7:58 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Ah - sorry for the breakage (didn't see this on any bots). Most/all of the LLVM debug code never brings in the 'dwarf' namespace, I guess you've got some code that does. Probably better to remove the 'using namespace dwarf' and add a few 'dwarf::' around the place, rather than adding 'llvm::', but whichever way suits your coding conventions/styles should address the issue.
> 
> 
> On Mon, Oct 21, 2013 at 7:56 PM, Ed Maste <emaste at freebsd.org> wrote:
> On 21 October 2013 20:24, Michael Sartain <mikesart at gmail.com> wrote:
> > I'm running into build errors at current top of tree (r193132). Anyone else
> > seeing these?
> 
> Yes, after updating llvm from 193083 to 193137 I see this when
> building lldb as well.  It looks like it's r193091.
> 
> It builds for me with this change:
> 
> diff --git a/source/Expression/IRForTarget.cpp
> b/source/Expression/IRForTarget.cpp
> index cac3fdf..4d14ebd 100644
> --- a/source/Expression/IRForTarget.cpp
> +++ b/source/Expression/IRForTarget.cpp
> @@ -361,8 +361,8 @@ IRForTarget::ResolveFunctionPointers(llvm::Module
> &llvm_module)
>          // be called with the builtin attribute on call sites. Remove any such
>          // attributes since it's illegal to have a builtin call to something
>          // other than a nobuiltin function.
> -        if (fun->hasFnAttribute(Attribute::NoBuiltin)) {
> -            Attribute builtin = Attribute::get(fun->getContext(),
> Attribute::Builtin);
> +        if (fun->hasFnAttribute(llvm::Attribute::NoBuiltin)) {
> +            llvm::Attribute builtin =
> llvm::Attribute::get(fun->getContext(), llvm::Attribute::Builtin);
> 
>              for (auto u = fun->use_begin(), e = fun->use_end(); u != e; ++u) {
>                  if (auto call = dyn_cast<CallInst>(*u)) {
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev