[lldb-dev] WatchpointLocation's tid

[Jim Ingham]

The Watchpoint code is a sketch I put in quite early on that, as you can tell, doesn't actually do anything.  So it's not too surprising that it has bit-rotted.

I'll fix all this when I get around to implementing watchpoints, but feel free to do anything you need to the WatchpointLocation classes to shut them up for now.

Jim

On Jan 18, 2011, at 4:13 PM, Bruce Mitchener wrote:

> I was working on a patch that experimentally adds __attribute__(format(printf, ...))) annotations to the various logging and printing functions and cleaning up some of the warnings that that generated.  In doing so, I noticed that this code:
> 
> WatchpointLocation::WatchpointLocation (lldb::addr_t addr, lldb::tid_t tid, bool hardware) :
>     StoppointLocation (GetNextID(), addr, tid, hardware),
> 
> Seems a bit wrong ...
> 
> It is taking the tid and passing it to StoppointLocation, but StoppointLocation's constructor interprets that as a size parameter instead.  (Then, later, WatchpointLocation has a log message that should include the TID, but it doesn't, resulting in too few arguments to the printf statement.)
> 
>  - Bruce
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev