<div dir="ltr">Thanks for the details!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Nov 14, 2021 at 3:39 PM Matheus Izvekov <<a href="mailto:mizvekov@gmail.com">mizvekov@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Oops, my bad!<br>
<br>
The reason for reverting this is that this is a recent commit, and<br>
there are reports of breakage building libANGLE which have not been<br>
investigated.<br>
<br>
See <a href="https://reviews.llvm.org/D110216" rel="noreferrer" target="_blank">https://reviews.llvm.org/D110216</a> for details / future developments.<br>
<br>
Thanks!<br>
<br>
On Mon, Nov 15, 2021 at 12:33 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Sun, Nov 14, 2021 at 3:30 PM Matheus Izvekov via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>><br>
>> Author: Matheus Izvekov<br>
>> Date: 2021-11-15T00:29:05+01:00<br>
>> New Revision: 6438a52df1c7f36952b6126ff7b978861b76ad45<br>
>><br>
>> URL: <a href="https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45</a><br>
>> DIFF: <a href="https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/6438a52df1c7f36952b6126ff7b978861b76ad45.diff</a><br>
>><br>
>> LOG: Revert "[clang] retain type sugar in auto / template argument deduction"<br>
>><br>
>> This reverts commit 4d8fff477e024698facd89741cc6cf996708d598.<br>
><br>
><br>
> Would be good to include some details about the reason for reverting patches in the commit message - helps folks identify whether a particular revert will address issues they might be investigating, and increases the chance folks might avoid the same mistakes if they're pursuing a similar direction in the future.<br>
</blockquote></div>