<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Am obviously brand new to your process and a bit of an old dog when it comes to learning new tricks. Would you prefer I make a new submission with the -U999999 diff? Also, am more than willing to help with the Java tests if that would be useful.</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Raphael Isemann via Phabricator <reviews@reviews.llvm.org><br>
<b>Sent:</b> Friday, October 8, 2021 10:46:50 AM<br>
<b>To:</b> David Millar; anoronha@apple.com; fallkrum@yahoo.com; kkleine@redhat.com; medismail.bennani@gmail.com; jonas@devlieghere.com; tedwood@quicinc.com; jmolenda@apple.com; syaghmour@apple.com; jingham@apple.com; vsk@apple.com; boris.ulasevich@gmail.com;
lldb-commits@lists.llvm.org; h.imai.833@nitech.jp; bruce.mitchener@gmail.com; david.spickett@linaro.org; quic_sourabhs@quicinc.com; djordje.todorovic@syrmia.com; serhiy.redko@gmail.com; Liburd1994@outlook.com<br>
<b>Cc:</b> mgorny@gentoo.org<br>
<b>Subject:</b> [PATCH] D111409: proposed support for Java interface to Scripting Bridge</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">teemperor added a comment.<br>
<br>
In D111409#3051110 <<a href="https://reviews.llvm.org/D111409#3051110">https://reviews.llvm.org/D111409#3051110</a>>, @d-millar wrote:<br>
<br>
> Apologies for the inclusion of that last file "patch" - that is the "git diff -U9999999" result, should that be useful.<br>
<br>
You can just upload that diff file and Phabricator will display it properly. There is no need to include the raw diff as part of the patch itself (it just makes this diff 100 times larger than it needs to be) :)<br>
<br>
Anyway, I think this seems like a reasonable thing to have. We have to figure out though how we can properly set up some Java tests for this and it would be nice if we also find a bot that could actually run the tests for us.<br>
<br>
<br>
<br>
================<br>
Comment at: lldb/bindings/java/CMakeLists.txt:3<br>
+ * IP: Apache License 2.0 with LLVM Exceptions<br>
+ */<br>
+add_custom_command(<br>
----------------<br>
I don't think CMake accepts this as a comment and I think we anyway don't put license headers in CMake scripts.<br>
<br>
<br>
================<br>
Comment at: lldb/source/API/CMakeLists.txt:84<br>
SBTrace.cpp<br>
+ SBTraceOptions.cpp<br>
SBType.cpp<br>
----------------<br>
I think this is some conflict with one of the SBTrace patches.<br>
<br>
<br>
Repository:<br>
rLLDB LLDB<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D111409/new/">https://reviews.llvm.org/D111409/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D111409">https://reviews.llvm.org/D111409</a><br>
<br>
</div>
</span></font>
</body>
</html>