<div dir="ltr">Any chance of removing some of these entirely, when they're the default (like the first class in this patch, `CommandHistory` - a default ctor (assuming it has no other ctors) and dtor are implicit, and don't need to be written out)?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Feb 28, 2021 at 8:24 AM Tatyana Krasnukha via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Tatyana Krasnukha<br>
Date: 2021-02-28T19:23:16+03:00<br>
New Revision: 54d03a4985bc9a0a84c4dff835ec6ed0f607582f<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/54d03a4985bc9a0a84c4dff835ec6ed0f607582f" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/54d03a4985bc9a0a84c4dff835ec6ed0f607582f</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/54d03a4985bc9a0a84c4dff835ec6ed0f607582f.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/54d03a4985bc9a0a84c4dff835ec6ed0f607582f.diff</a><br>
<br>
LOG: [lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default"<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
lldb/include/lldb/Interpreter/CommandHistory.h<br>
lldb/include/lldb/Interpreter/CommandObject.h<br>
lldb/include/lldb/Interpreter/CommandReturnObject.h<br>
lldb/include/lldb/Interpreter/OptionGroupArchitecture.h<br>
lldb/include/lldb/Interpreter/OptionGroupBoolean.h<br>
lldb/include/lldb/Interpreter/OptionGroupFile.h<br>
lldb/include/lldb/Interpreter/OptionGroupFormat.h<br>
lldb/include/lldb/Interpreter/OptionGroupOutputFile.h<br>
lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h<br>
lldb/include/lldb/Interpreter/OptionGroupString.h<br>
lldb/include/lldb/Interpreter/OptionGroupUInt64.h<br>
lldb/include/lldb/Interpreter/OptionGroupUUID.h<br>
lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h<br>
lldb/include/lldb/Interpreter/OptionGroupVariable.h<br>
lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h<br>
lldb/include/lldb/Interpreter/OptionValueArch.h<br>
lldb/include/lldb/Interpreter/OptionValueArgs.h<br>
lldb/include/lldb/Interpreter/OptionValueArray.h<br>
lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
lldb/include/lldb/Interpreter/OptionValueChar.h<br>
lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
lldb/include/lldb/Interpreter/OptionValueEnumeration.h<br>
lldb/include/lldb/Interpreter/OptionValueFileColonLine.h<br>
lldb/include/lldb/Interpreter/OptionValueFileSpec.h<br>
lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
lldb/include/lldb/Interpreter/OptionValueFormatEntity.h<br>
lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
lldb/include/lldb/Interpreter/OptionValueProperties.h<br>
lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
lldb/include/lldb/Interpreter/OptionValueString.h<br>
lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
lldb/include/lldb/Interpreter/ScriptInterpreter.h<br>
lldb/source/Interpreter/CommandHistory.cpp<br>
lldb/source/Interpreter/CommandObject.cpp<br>
lldb/source/Interpreter/CommandReturnObject.cpp<br>
lldb/source/Interpreter/OptionGroupArchitecture.cpp<br>
lldb/source/Interpreter/OptionGroupBoolean.cpp<br>
lldb/source/Interpreter/OptionGroupFile.cpp<br>
lldb/source/Interpreter/OptionGroupFormat.cpp<br>
lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
lldb/source/Interpreter/OptionGroupString.cpp<br>
lldb/source/Interpreter/OptionGroupUInt64.cpp<br>
lldb/source/Interpreter/OptionGroupUUID.cpp<br>
lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp<br>
lldb/source/Interpreter/OptionGroupVariable.cpp<br>
lldb/source/Interpreter/OptionGroupWatchpoint.cpp<br>
lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
lldb/source/Interpreter/Options.cpp<br>
lldb/source/Interpreter/ScriptInterpreter.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/lldb/include/lldb/Interpreter/CommandHistory.h b/lldb/include/lldb/Interpreter/CommandHistory.h<br>
index fbb42247f11a..12c170ba5eeb 100644<br>
--- a/lldb/include/lldb/Interpreter/CommandHistory.h<br>
+++ b/lldb/include/lldb/Interpreter/CommandHistory.h<br>
@@ -20,9 +20,9 @@ namespace lldb_private {<br>
<br>
class CommandHistory {<br>
public:<br>
- CommandHistory();<br>
+ CommandHistory() = default;<br>
<br>
- ~CommandHistory();<br>
+ ~CommandHistory() = default;<br>
<br>
size_t GetSize() const;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/CommandObject.h b/lldb/include/lldb/Interpreter/CommandObject.h<br>
index d5ad969cda66..8bc5d3e22355 100644<br>
--- a/lldb/include/lldb/Interpreter/CommandObject.h<br>
+++ b/lldb/include/lldb/Interpreter/CommandObject.h<br>
@@ -113,7 +113,7 @@ class CommandObject {<br>
llvm::StringRef help = "", llvm::StringRef syntax = "",<br>
uint32_t flags = 0);<br>
<br>
- virtual ~CommandObject();<br>
+ virtual ~CommandObject() = default;<br>
<br>
static const char *<br>
GetArgumentTypeAsCString(const lldb::CommandArgumentType arg_type);<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/CommandReturnObject.h b/lldb/include/lldb/Interpreter/CommandReturnObject.h<br>
index 06b648517d13..c638b4bc70b2 100644<br>
--- a/lldb/include/lldb/Interpreter/CommandReturnObject.h<br>
+++ b/lldb/include/lldb/Interpreter/CommandReturnObject.h<br>
@@ -26,7 +26,7 @@ class CommandReturnObject {<br>
public:<br>
CommandReturnObject(bool colors);<br>
<br>
- ~CommandReturnObject();<br>
+ ~CommandReturnObject() = default;<br>
<br>
llvm::StringRef GetOutputData() {<br>
lldb::StreamSP stream_sp(m_out_stream.GetStreamAtIndex(eStreamStringIndex));<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupArchitecture.h b/lldb/include/lldb/Interpreter/OptionGroupArchitecture.h<br>
index 1eadf45bae47..4655a68f1e4a 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupArchitecture.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupArchitecture.h<br>
@@ -18,9 +18,9 @@ namespace lldb_private {<br>
<br>
class OptionGroupArchitecture : public OptionGroup {<br>
public:<br>
- OptionGroupArchitecture();<br>
+ OptionGroupArchitecture() = default;<br>
<br>
- ~OptionGroupArchitecture() override;<br>
+ ~OptionGroupArchitecture() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupBoolean.h b/lldb/include/lldb/Interpreter/OptionGroupBoolean.h<br>
index 5411e99148e6..9e2dad5d9c2a 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupBoolean.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupBoolean.h<br>
@@ -25,7 +25,7 @@ class OptionGroupBoolean : public OptionGroup {<br>
const char *usage_text, bool default_value,<br>
bool no_argument_toggle_default);<br>
<br>
- ~OptionGroupBoolean() override;<br>
+ ~OptionGroupBoolean() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override {<br>
return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupFile.h b/lldb/include/lldb/Interpreter/OptionGroupFile.h<br>
index 22b0eb4a28fa..1e4eb35eade4 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupFile.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupFile.h<br>
@@ -24,7 +24,7 @@ class OptionGroupFile : public OptionGroup {<br>
lldb::CommandArgumentType argument_type,<br>
const char *usage_text);<br>
<br>
- ~OptionGroupFile() override;<br>
+ ~OptionGroupFile() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override {<br>
return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupFormat.h b/lldb/include/lldb/Interpreter/OptionGroupFormat.h<br>
index 62c6f97c6214..2d445b8a6c20 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupFormat.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupFormat.h<br>
@@ -32,13 +32,12 @@ class OptionGroupFormat : public OptionGroup {<br>
uint64_t default_count =<br>
UINT64_MAX); // Pass UINT64_MAX to disable the "--count" option<br>
<br>
- ~OptionGroupFormat() override;<br>
+ ~OptionGroupFormat() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;<br>
<br>
Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_value,<br>
ExecutionContext *execution_context) override;<br>
- Status SetOptionValue(uint32_t, const char *, ExecutionContext *) = delete;<br>
<br>
void OptionParsingStarting(ExecutionContext *execution_context) override;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupOutputFile.h b/lldb/include/lldb/Interpreter/OptionGroupOutputFile.h<br>
index a71998f3bc1a..3902247cfb3e 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupOutputFile.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupOutputFile.h<br>
@@ -20,13 +20,12 @@ class OptionGroupOutputFile : public OptionGroup {<br>
public:<br>
OptionGroupOutputFile();<br>
<br>
- ~OptionGroupOutputFile() override;<br>
+ ~OptionGroupOutputFile() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;<br>
<br>
Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_value,<br>
ExecutionContext *execution_context) override;<br>
- Status SetOptionValue(uint32_t, const char *, ExecutionContext *) = delete;<br>
<br>
void OptionParsingStarting(ExecutionContext *execution_context) override;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h b/lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h<br>
index 695a5b93c2ea..7ad4bc092678 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h<br>
@@ -29,7 +29,7 @@ class OptionGroupPythonClassWithDict : public OptionGroup {<br>
int key_option = 'k', <br>
int value_option = 'v');<br>
<br>
- ~OptionGroupPythonClassWithDict() override;<br>
+ ~OptionGroupPythonClassWithDict() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override {<br>
return llvm::ArrayRef<OptionDefinition>(m_option_definition);<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupString.h b/lldb/include/lldb/Interpreter/OptionGroupString.h<br>
index de1ef0b4bf3c..aa0225639035 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupString.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupString.h<br>
@@ -22,7 +22,7 @@ class OptionGroupString : public OptionGroup {<br>
lldb::CommandArgumentType argument_type,<br>
const char *usage_text, const char *default_value);<br>
<br>
- ~OptionGroupString() override;<br>
+ ~OptionGroupString() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override {<br>
return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupUInt64.h b/lldb/include/lldb/Interpreter/OptionGroupUInt64.h<br>
index 1e21f56d4338..710591725409 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupUInt64.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupUInt64.h<br>
@@ -23,7 +23,7 @@ class OptionGroupUInt64 : public OptionGroup {<br>
lldb::CommandArgumentType argument_type,<br>
const char *usage_text, uint64_t default_value);<br>
<br>
- ~OptionGroupUInt64() override;<br>
+ ~OptionGroupUInt64() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override {<br>
return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupUUID.h b/lldb/include/lldb/Interpreter/OptionGroupUUID.h<br>
index b93d99debf6e..4ca2a94b7fb3 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupUUID.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupUUID.h<br>
@@ -18,9 +18,9 @@ namespace lldb_private {<br>
<br>
class OptionGroupUUID : public OptionGroup {<br>
public:<br>
- OptionGroupUUID();<br>
+ OptionGroupUUID() = default;<br>
<br>
- ~OptionGroupUUID() override;<br>
+ ~OptionGroupUUID() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h b/lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h<br>
index 07879e5dac1f..56452f4956f2 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h<br>
@@ -18,9 +18,9 @@ namespace lldb_private {<br>
<br>
class OptionGroupValueObjectDisplay : public OptionGroup {<br>
public:<br>
- OptionGroupValueObjectDisplay();<br>
+ OptionGroupValueObjectDisplay() = default;<br>
<br>
- ~OptionGroupValueObjectDisplay() override;<br>
+ ~OptionGroupValueObjectDisplay() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupVariable.h b/lldb/include/lldb/Interpreter/OptionGroupVariable.h<br>
index 4ba1e09d840f..c9f1283d4de2 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupVariable.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupVariable.h<br>
@@ -20,7 +20,7 @@ class OptionGroupVariable : public OptionGroup {<br>
public:<br>
OptionGroupVariable(bool show_frame_options);<br>
<br>
- ~OptionGroupVariable() override;<br>
+ ~OptionGroupVariable() override = default;<br>
<br>
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h b/lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h<br>
index 054af4f1ce07..33818043cf63 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h<br>
@@ -17,9 +17,9 @@ namespace lldb_private {<br>
<br>
class OptionGroupWatchpoint : public OptionGroup {<br>
public:<br>
- OptionGroupWatchpoint();<br>
+ OptionGroupWatchpoint() = default;<br>
<br>
- ~OptionGroupWatchpoint() override;<br>
+ ~OptionGroupWatchpoint() override = default;<br>
<br>
static bool IsWatchSizeSupported(uint32_t watch_size);<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueArch.h b/lldb/include/lldb/Interpreter/OptionValueArch.h<br>
index 5047db775fc2..d079b3896531 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueArch.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueArch.h<br>
@@ -17,7 +17,7 @@ namespace lldb_private {<br>
<br>
class OptionValueArch : public OptionValue {<br>
public:<br>
- OptionValueArch() : OptionValue(), m_current_value(), m_default_value() {}<br>
+ OptionValueArch() = default;<br>
<br>
OptionValueArch(const char *triple)<br>
: OptionValue(), m_current_value(triple), m_default_value() {<br>
@@ -31,7 +31,7 @@ class OptionValueArch : public OptionValue {<br>
: OptionValue(), m_current_value(current_value),<br>
m_default_value(default_value) {}<br>
<br>
- ~OptionValueArch() override {}<br>
+ ~OptionValueArch() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueArgs.h b/lldb/include/lldb/Interpreter/OptionValueArgs.h<br>
index 25f7fdde0bf3..2ef6ca5573e9 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueArgs.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueArgs.h<br>
@@ -19,7 +19,7 @@ class OptionValueArgs : public OptionValueArray {<br>
: OptionValueArray(<br>
OptionValue::ConvertTypeToMask(OptionValue::eTypeString)) {}<br>
<br>
- ~OptionValueArgs() override {}<br>
+ ~OptionValueArgs() override = default;<br>
<br>
size_t GetArgs(Args &args);<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueArray.h b/lldb/include/lldb/Interpreter/OptionValueArray.h<br>
index 14bc28404ec3..44bde8ee8699 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueArray.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueArray.h<br>
@@ -20,7 +20,7 @@ class OptionValueArray : public OptionValue {<br>
OptionValueArray(uint32_t type_mask = UINT32_MAX, bool raw_value_dump = false)<br>
: m_type_mask(type_mask), m_values(), m_raw_value_dump(raw_value_dump) {}<br>
<br>
- ~OptionValueArray() override {}<br>
+ ~OptionValueArray() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueBoolean.h b/lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
index 6b58eb94b826..d0eb4362d466 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
@@ -21,7 +21,7 @@ class OptionValueBoolean : public OptionValue {<br>
: OptionValue(), m_current_value(current_value),<br>
m_default_value(default_value) {}<br>
<br>
- ~OptionValueBoolean() override {}<br>
+ ~OptionValueBoolean() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueChar.h b/lldb/include/lldb/Interpreter/OptionValueChar.h<br>
index b5b39b77b9b7..f3fd28104067 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueChar.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueChar.h<br>
@@ -22,7 +22,7 @@ class OptionValueChar : public OptionValue {<br>
: OptionValue(), m_current_value(current_value),<br>
m_default_value(default_value) {}<br>
<br>
- ~OptionValueChar() override {}<br>
+ ~OptionValueChar() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueDictionary.h b/lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
index dab1c3ea0c1c..e645f32cb800 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
@@ -22,7 +22,7 @@ class OptionValueDictionary : public OptionValue {<br>
: OptionValue(), m_type_mask(type_mask), m_values(),<br>
m_raw_value_dump(raw_value_dump) {}<br>
<br>
- ~OptionValueDictionary() override {}<br>
+ ~OptionValueDictionary() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueEnumeration.h b/lldb/include/lldb/Interpreter/OptionValueEnumeration.h<br>
index 5ef6fa54ab82..0fe70193dece 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueEnumeration.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueEnumeration.h<br>
@@ -31,7 +31,7 @@ class OptionValueEnumeration : public OptionValue {<br>
<br>
OptionValueEnumeration(const OptionEnumValues &enumerators, enum_type value);<br>
<br>
- ~OptionValueEnumeration() override;<br>
+ ~OptionValueEnumeration() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h b/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h<br>
index b3bb1f0e7ca2..86fd0d5aec2c 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h<br>
@@ -21,7 +21,7 @@ class OptionValueFileColonLine : public OptionValue {<br>
OptionValueFileColonLine();<br>
OptionValueFileColonLine(const llvm::StringRef input);<br>
<br>
- ~OptionValueFileColonLine() override {}<br>
+ ~OptionValueFileColonLine() override = default;<br>
<br>
OptionValue::Type GetType() const override { return eTypeFileLineColumn; }<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFileSpec.h b/lldb/include/lldb/Interpreter/OptionValueFileSpec.h<br>
index a71858674c0a..4168e4b1b542 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFileSpec.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFileSpec.h<br>
@@ -25,7 +25,7 @@ class OptionValueFileSpec : public OptionValue {<br>
OptionValueFileSpec(const FileSpec ¤t_value,<br>
const FileSpec &default_value, bool resolve = true);<br>
<br>
- ~OptionValueFileSpec() override {}<br>
+ ~OptionValueFileSpec() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h b/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
index dcf926fca8d8..b2dc11b7745a 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
@@ -18,12 +18,12 @@ namespace lldb_private {<br>
<br>
class OptionValueFileSpecList : public OptionValue {<br>
public:<br>
- OptionValueFileSpecList() : OptionValue(), m_current_value() {}<br>
+ OptionValueFileSpecList() = default;<br>
<br>
OptionValueFileSpecList(const FileSpecList ¤t_value)<br>
: OptionValue(), m_current_value(current_value) {}<br>
<br>
- ~OptionValueFileSpecList() override {}<br>
+ ~OptionValueFileSpecList() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFormat.h b/lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
index 9241ba6bb9a7..eb80f09bb092 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
@@ -22,7 +22,7 @@ class OptionValueFormat : public OptionValue {<br>
: OptionValue(), m_current_value(current_value),<br>
m_default_value(default_value) {}<br>
<br>
- ~OptionValueFormat() override {}<br>
+ ~OptionValueFormat() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h b/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h<br>
index a29b7f4044b4..4100ee2bc2ef 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h<br>
@@ -18,7 +18,7 @@ class OptionValueFormatEntity : public OptionValue {<br>
public:<br>
OptionValueFormatEntity(const char *default_format);<br>
<br>
- ~OptionValueFormatEntity() override {}<br>
+ ~OptionValueFormatEntity() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueLanguage.h b/lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
index bf86f3c371cf..bfe953a53c98 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
@@ -25,7 +25,7 @@ class OptionValueLanguage : public OptionValue {<br>
: OptionValue(), m_current_value(current_value),<br>
m_default_value(default_value) {}<br>
<br>
- ~OptionValueLanguage() override {}<br>
+ ~OptionValueLanguage() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValuePathMappings.h b/lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
index 8f58d5d935e7..e8af4bb23535 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
@@ -19,7 +19,7 @@ class OptionValuePathMappings : public OptionValue {<br>
OptionValuePathMappings(bool notify_changes)<br>
: OptionValue(), m_path_mappings(), m_notify_changes(notify_changes) {}<br>
<br>
- ~OptionValuePathMappings() override {}<br>
+ ~OptionValuePathMappings() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueProperties.h b/lldb/include/lldb/Interpreter/OptionValueProperties.h<br>
index d60afdeb46fb..d17f123ce474 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueProperties.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueProperties.h<br>
@@ -23,8 +23,7 @@ class OptionValueProperties<br>
: public OptionValue,<br>
public std::enable_shared_from_this<OptionValueProperties> {<br>
public:<br>
- OptionValueProperties()<br>
- : OptionValue(), m_name(), m_properties(), m_name_to_index() {}<br>
+ OptionValueProperties() = default;<br>
<br>
OptionValueProperties(ConstString name);<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueSInt64.h b/lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
index 2faea04d07f9..625193f87583 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
@@ -16,9 +16,7 @@ namespace lldb_private {<br>
<br>
class OptionValueSInt64 : public OptionValue {<br>
public:<br>
- OptionValueSInt64()<br>
- : OptionValue(), m_current_value(0), m_default_value(0),<br>
- m_min_value(INT64_MIN), m_max_value(INT64_MAX) {}<br>
+ OptionValueSInt64() = default;<br>
<br>
OptionValueSInt64(int64_t value)<br>
: OptionValue(), m_current_value(value), m_default_value(value),<br>
@@ -29,12 +27,9 @@ class OptionValueSInt64 : public OptionValue {<br>
m_default_value(default_value), m_min_value(INT64_MIN),<br>
m_max_value(INT64_MAX) {}<br>
<br>
- OptionValueSInt64(const OptionValueSInt64 &rhs)<br>
- : OptionValue(rhs), m_current_value(rhs.m_current_value),<br>
- m_default_value(rhs.m_default_value), m_min_value(rhs.m_min_value),<br>
- m_max_value(rhs.m_max_value) {}<br>
+ OptionValueSInt64(const OptionValueSInt64 &rhs) = default;<br>
<br>
- ~OptionValueSInt64() override {}<br>
+ ~OptionValueSInt64() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
@@ -90,10 +85,10 @@ class OptionValueSInt64 : public OptionValue {<br>
int64_t GetMaximumValue() const { return m_max_value; }<br>
<br>
protected:<br>
- int64_t m_current_value;<br>
- int64_t m_default_value;<br>
- int64_t m_min_value;<br>
- int64_t m_max_value;<br>
+ int64_t m_current_value = 0;<br>
+ int64_t m_default_value = 0;<br>
+ int64_t m_min_value = INT64_MIN;<br>
+ int64_t m_max_value = INT64_MAX;<br>
};<br>
<br>
} // namespace lldb_private<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueString.h b/lldb/include/lldb/Interpreter/OptionValueString.h<br>
index c592ff1281eb..4d78cbb64e5a 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueString.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueString.h<br>
@@ -23,9 +23,7 @@ class OptionValueString : public OptionValue {<br>
<br>
enum Options { eOptionEncodeCharacterEscapeSequences = (1u << 0) };<br>
<br>
- OptionValueString()<br>
- : OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
- m_validator(), m_validator_baton() {}<br>
+ OptionValueString() = default;<br>
<br>
OptionValueString(ValidatorCallback validator, void *baton = nullptr)<br>
: OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
@@ -125,8 +123,8 @@ class OptionValueString : public OptionValue {<br>
std::string m_current_value;<br>
std::string m_default_value;<br>
Flags m_options;<br>
- ValidatorCallback m_validator;<br>
- void *m_validator_baton;<br>
+ ValidatorCallback m_validator = nullptr;<br>
+ void *m_validator_baton = nullptr;<br>
};<br>
<br>
} // namespace lldb_private<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueUInt64.h b/lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
index 47162334fb65..bee8ff5117a9 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
@@ -16,7 +16,7 @@ namespace lldb_private {<br>
<br>
class OptionValueUInt64 : public OptionValue {<br>
public:<br>
- OptionValueUInt64() : OptionValue(), m_current_value(0), m_default_value(0) {}<br>
+ OptionValueUInt64() = default;<br>
<br>
OptionValueUInt64(uint64_t value)<br>
: OptionValue(), m_current_value(value), m_default_value(value) {}<br>
@@ -25,7 +25,7 @@ class OptionValueUInt64 : public OptionValue {<br>
: OptionValue(), m_current_value(current_value),<br>
m_default_value(default_value) {}<br>
<br>
- ~OptionValueUInt64() override {}<br>
+ ~OptionValueUInt64() override = default;<br>
<br>
// Decode a uint64_t from "value_cstr" return a OptionValueUInt64 object<br>
// inside of a lldb::OptionValueSP object if all goes well. If the string<br>
@@ -68,8 +68,8 @@ class OptionValueUInt64 : public OptionValue {<br>
void SetDefaultValue(uint64_t value) { m_default_value = value; }<br>
<br>
protected:<br>
- uint64_t m_current_value;<br>
- uint64_t m_default_value;<br>
+ uint64_t m_current_value = 0;<br>
+ uint64_t m_default_value = 0;<br>
};<br>
<br>
} // namespace lldb_private<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueUUID.h b/lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
index 822dc0019851..1673078344f5 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
@@ -16,11 +16,11 @@ namespace lldb_private {<br>
<br>
class OptionValueUUID : public OptionValue {<br>
public:<br>
- OptionValueUUID() : OptionValue(), m_uuid() {}<br>
+ OptionValueUUID() = default;<br>
<br>
OptionValueUUID(const UUID &uuid) : OptionValue(), m_uuid(uuid) {}<br>
<br>
- ~OptionValueUUID() override {}<br>
+ ~OptionValueUUID() override = default;<br>
<br>
// Virtual subclass pure virtual overrides<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/ScriptInterpreter.h b/lldb/include/lldb/Interpreter/ScriptInterpreter.h<br>
index 4abd1ca68167..275d61a63f05 100644<br>
--- a/lldb/include/lldb/Interpreter/ScriptInterpreter.h<br>
+++ b/lldb/include/lldb/Interpreter/ScriptInterpreter.h<br>
@@ -85,7 +85,7 @@ class ScriptInterpreter : public PluginInterface {<br>
<br>
ScriptInterpreter(Debugger &debugger, lldb::ScriptLanguage script_lang);<br>
<br>
- ~ScriptInterpreter() override;<br>
+ ~ScriptInterpreter() override = default;<br>
<br>
struct ExecuteScriptOptions {<br>
public:<br>
<br>
diff --git a/lldb/source/Interpreter/CommandHistory.cpp b/lldb/source/Interpreter/CommandHistory.cpp<br>
index 9c7919ecc41f..ffdcbbfb4831 100644<br>
--- a/lldb/source/Interpreter/CommandHistory.cpp<br>
+++ b/lldb/source/Interpreter/CommandHistory.cpp<br>
@@ -13,10 +13,6 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-CommandHistory::CommandHistory() : m_mutex(), m_history() {}<br>
-<br>
-CommandHistory::~CommandHistory() {}<br>
-<br>
size_t CommandHistory::GetSize() const {<br>
std::lock_guard<std::recursive_mutex> guard(m_mutex);<br>
return m_history.size();<br>
<br>
diff --git a/lldb/source/Interpreter/CommandObject.cpp b/lldb/source/Interpreter/CommandObject.cpp<br>
index 71adf8c39f1b..9d27de46e382 100644<br>
--- a/lldb/source/Interpreter/CommandObject.cpp<br>
+++ b/lldb/source/Interpreter/CommandObject.cpp<br>
@@ -49,8 +49,6 @@ CommandObject::CommandObject(CommandInterpreter &interpreter,<br>
m_cmd_syntax = std::string(syntax);<br>
}<br>
<br>
-CommandObject::~CommandObject() {}<br>
-<br>
Debugger &CommandObject::GetDebugger() { return m_interpreter.GetDebugger(); }<br>
<br>
llvm::StringRef CommandObject::GetHelp() { return m_cmd_help_short; }<br>
<br>
diff --git a/lldb/source/Interpreter/CommandReturnObject.cpp b/lldb/source/Interpreter/CommandReturnObject.cpp<br>
index 441a8e08e6bc..77d94bd9389c 100644<br>
--- a/lldb/source/Interpreter/CommandReturnObject.cpp<br>
+++ b/lldb/source/Interpreter/CommandReturnObject.cpp<br>
@@ -45,8 +45,6 @@ CommandReturnObject::CommandReturnObject(bool colors)<br>
m_status(eReturnStatusStarted), m_did_change_process_state(false),<br>
m_interactive(true) {}<br>
<br>
-CommandReturnObject::~CommandReturnObject() {}<br>
-<br>
void CommandReturnObject::AppendErrorWithFormat(const char *format, ...) {<br>
if (!format)<br>
return;<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupArchitecture.cpp b/lldb/source/Interpreter/OptionGroupArchitecture.cpp<br>
index baca1c6e8068..00541b7198d2 100644<br>
--- a/lldb/source/Interpreter/OptionGroupArchitecture.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupArchitecture.cpp<br>
@@ -13,10 +13,6 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-OptionGroupArchitecture::OptionGroupArchitecture() : m_arch_str() {}<br>
-<br>
-OptionGroupArchitecture::~OptionGroupArchitecture() {}<br>
-<br>
static constexpr OptionDefinition g_option_table[] = {<br>
{LLDB_OPT_SET_1, false, "arch", 'a', OptionParser::eRequiredArgument,<br>
nullptr, {}, 0, eArgTypeArchitecture,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupBoolean.cpp b/lldb/source/Interpreter/OptionGroupBoolean.cpp<br>
index 3482e784ca0c..3f73893fca96 100644<br>
--- a/lldb/source/Interpreter/OptionGroupBoolean.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupBoolean.cpp<br>
@@ -33,8 +33,6 @@ OptionGroupBoolean::OptionGroupBoolean(uint32_t usage_mask, bool required,<br>
m_option_definition.usage_text = usage_text;<br>
}<br>
<br>
-OptionGroupBoolean::~OptionGroupBoolean() {}<br>
-<br>
Status OptionGroupBoolean::SetOptionValue(uint32_t option_idx,<br>
llvm::StringRef option_value,<br>
ExecutionContext *execution_context) {<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupFile.cpp b/lldb/source/Interpreter/OptionGroupFile.cpp<br>
index 9d9be5b6f178..8be4b18a2134 100644<br>
--- a/lldb/source/Interpreter/OptionGroupFile.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupFile.cpp<br>
@@ -31,8 +31,6 @@ OptionGroupFile::OptionGroupFile(uint32_t usage_mask, bool required,<br>
m_option_definition.usage_text = usage_text;<br>
}<br>
<br>
-OptionGroupFile::~OptionGroupFile() {}<br>
-<br>
Status OptionGroupFile::SetOptionValue(uint32_t option_idx,<br>
llvm::StringRef option_arg,<br>
ExecutionContext *execution_context) {<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupFormat.cpp b/lldb/source/Interpreter/OptionGroupFormat.cpp<br>
index 0052f72b0550..1cc5e70282c1 100644<br>
--- a/lldb/source/Interpreter/OptionGroupFormat.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupFormat.cpp<br>
@@ -24,8 +24,6 @@ OptionGroupFormat::OptionGroupFormat(lldb::Format default_format,<br>
m_count(default_count, default_count), m_prev_gdb_format('x'),<br>
m_prev_gdb_size('w') {}<br>
<br>
-OptionGroupFormat::~OptionGroupFormat() {}<br>
-<br>
static constexpr OptionDefinition g_option_table[] = {<br>
{LLDB_OPT_SET_1, false, "format", 'f', OptionParser::eRequiredArgument,<br>
nullptr, {}, 0, eArgTypeFormat,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupOutputFile.cpp b/lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
index 65105c3e0180..1f3050834ec3 100644<br>
--- a/lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
@@ -16,8 +16,6 @@ using namespace lldb_private;<br>
OptionGroupOutputFile::OptionGroupOutputFile()<br>
: m_file(), m_append(false, false) {}<br>
<br>
-OptionGroupOutputFile::~OptionGroupOutputFile() {}<br>
-<br>
static const uint32_t SHORT_OPTION_APND = 0x61706e64; // 'apnd'<br>
<br>
static constexpr OptionDefinition g_option_table[] = {<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp b/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
index 217dab2ef63b..e768febebb89 100644<br>
--- a/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
@@ -81,8 +81,6 @@ OptionGroupPythonClassWithDict::OptionGroupPythonClassWithDict<br>
<br>
}<br>
<br>
-OptionGroupPythonClassWithDict::~OptionGroupPythonClassWithDict() {}<br>
-<br>
Status OptionGroupPythonClassWithDict::SetOptionValue(<br>
uint32_t option_idx,<br>
llvm::StringRef option_arg,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupString.cpp b/lldb/source/Interpreter/OptionGroupString.cpp<br>
index c9f78eb953f4..75faaac9f6dd 100644<br>
--- a/lldb/source/Interpreter/OptionGroupString.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupString.cpp<br>
@@ -32,8 +32,6 @@ OptionGroupString::OptionGroupString(uint32_t usage_mask, bool required,<br>
m_option_definition.usage_text = usage_text;<br>
}<br>
<br>
-OptionGroupString::~OptionGroupString() {}<br>
-<br>
Status OptionGroupString::SetOptionValue(uint32_t option_idx,<br>
llvm::StringRef option_arg,<br>
ExecutionContext *execution_context) {<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupUInt64.cpp b/lldb/source/Interpreter/OptionGroupUInt64.cpp<br>
index 309855d4718c..486941a7555a 100644<br>
--- a/lldb/source/Interpreter/OptionGroupUInt64.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupUInt64.cpp<br>
@@ -32,8 +32,6 @@ OptionGroupUInt64::OptionGroupUInt64(uint32_t usage_mask, bool required,<br>
m_option_definition.usage_text = usage_text;<br>
}<br>
<br>
-OptionGroupUInt64::~OptionGroupUInt64() {}<br>
-<br>
Status OptionGroupUInt64::SetOptionValue(uint32_t option_idx,<br>
llvm::StringRef option_arg,<br>
ExecutionContext *execution_context) {<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupUUID.cpp b/lldb/source/Interpreter/OptionGroupUUID.cpp<br>
index dc6f4139896f..5b4c24a0a32b 100644<br>
--- a/lldb/source/Interpreter/OptionGroupUUID.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupUUID.cpp<br>
@@ -13,10 +13,6 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-OptionGroupUUID::OptionGroupUUID() : m_uuid() {}<br>
-<br>
-OptionGroupUUID::~OptionGroupUUID() {}<br>
-<br>
static constexpr OptionDefinition g_option_table[] = {<br>
{LLDB_OPT_SET_1, false, "uuid", 'u', OptionParser::eRequiredArgument,<br>
nullptr, {}, 0, eArgTypeModuleUUID, "A module UUID value."},<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp b/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp<br>
index e0401f8987ad..04861b539650 100644<br>
--- a/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp<br>
@@ -19,10 +19,6 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-OptionGroupValueObjectDisplay::OptionGroupValueObjectDisplay() {}<br>
-<br>
-OptionGroupValueObjectDisplay::~OptionGroupValueObjectDisplay() {}<br>
-<br>
static const OptionDefinition g_option_table[] = {<br>
{LLDB_OPT_SET_1, false, "dynamic-type", 'd',<br>
OptionParser::eRequiredArgument, nullptr, GetDynamicValueTypes(), 0,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupVariable.cpp b/lldb/source/Interpreter/OptionGroupVariable.cpp<br>
index 9f57dbbd073e..2451a3e96478 100644<br>
--- a/lldb/source/Interpreter/OptionGroupVariable.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupVariable.cpp<br>
@@ -70,8 +70,6 @@ OptionGroupVariable::OptionGroupVariable(bool show_frame_options)<br>
: OptionGroup(), include_frame_options(show_frame_options),<br>
summary(ValidateNamedSummary), summary_string(ValidateSummaryString) {}<br>
<br>
-OptionGroupVariable::~OptionGroupVariable() {}<br>
-<br>
Status<br>
OptionGroupVariable::SetOptionValue(uint32_t option_idx,<br>
llvm::StringRef option_arg,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupWatchpoint.cpp b/lldb/source/Interpreter/OptionGroupWatchpoint.cpp<br>
index 07013b5b78fe..eb9842add28c 100644<br>
--- a/lldb/source/Interpreter/OptionGroupWatchpoint.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupWatchpoint.cpp<br>
@@ -74,10 +74,6 @@ bool OptionGroupWatchpoint::IsWatchSizeSupported(uint32_t watch_size) {<br>
return false;<br>
}<br>
<br>
-OptionGroupWatchpoint::OptionGroupWatchpoint() : OptionGroup() {}<br>
-<br>
-OptionGroupWatchpoint::~OptionGroupWatchpoint() {}<br>
-<br>
Status<br>
OptionGroupWatchpoint::SetOptionValue(uint32_t option_idx,<br>
llvm::StringRef option_arg,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionValueEnumeration.cpp b/lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
index 9a1e08d4fba0..8fcd8db1ee96 100644<br>
--- a/lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
+++ b/lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
@@ -20,8 +20,6 @@ OptionValueEnumeration::OptionValueEnumeration(<br>
SetEnumerations(enumerators);<br>
}<br>
<br>
-OptionValueEnumeration::~OptionValueEnumeration() {}<br>
-<br>
void OptionValueEnumeration::DumpValue(const ExecutionContext *exe_ctx,<br>
Stream &strm, uint32_t dump_mask) {<br>
if (dump_mask & eDumpOptionType)<br>
<br>
diff --git a/lldb/source/Interpreter/Options.cpp b/lldb/source/Interpreter/Options.cpp<br>
index 9ecc9e229e0e..5d3864dbfff3 100644<br>
--- a/lldb/source/Interpreter/Options.cpp<br>
+++ b/lldb/source/Interpreter/Options.cpp<br>
@@ -27,7 +27,7 @@ using namespace lldb_private;<br>
// Options<br>
Options::Options() : m_getopt_table() { BuildValidOptionSets(); }<br>
<br>
-Options::~Options() {}<br>
+Options::~Options() = default;<br>
<br>
void Options::NotifyOptionParsingStarting(ExecutionContext *execution_context) {<br>
m_seen_options.clear();<br>
<br>
diff --git a/lldb/source/Interpreter/ScriptInterpreter.cpp b/lldb/source/Interpreter/ScriptInterpreter.cpp<br>
index 013ed6aecb80..2c55d08497ab 100644<br>
--- a/lldb/source/Interpreter/ScriptInterpreter.cpp<br>
+++ b/lldb/source/Interpreter/ScriptInterpreter.cpp<br>
@@ -30,8 +30,6 @@ ScriptInterpreter::ScriptInterpreter(Debugger &debugger,<br>
lldb::ScriptLanguage script_lang)<br>
: m_debugger(debugger), m_script_lang(script_lang) {}<br>
<br>
-ScriptInterpreter::~ScriptInterpreter() {}<br>
-<br>
void ScriptInterpreter::CollectDataForBreakpointCommandCallback(<br>
std::vector<BreakpointOptions *> &bp_options_vec,<br>
CommandReturnObject &result) {<br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>