<div dir="ltr">Nice cleanup!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Feb 28, 2021 at 8:24 AM Tatyana Krasnukha via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Tatyana Krasnukha<br>
Date: 2021-02-28T19:23:18+03:00<br>
New Revision: 8cdcd41e384b4901cd796f7be58c461647e54d18<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/8cdcd41e384b4901cd796f7be58c461647e54d18" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8cdcd41e384b4901cd796f7be58c461647e54d18</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/8cdcd41e384b4901cd796f7be58c461647e54d18.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8cdcd41e384b4901cd796f7be58c461647e54d18.diff</a><br>
<br>
LOG: [lldb/Interpreter][NFC] Remove explicit default initialization of members and base classes<br>
<br>
According to clang-tidy's readability-redundant-member-init.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
lldb/include/lldb/Interpreter/OptionGroupPlatform.h<br>
lldb/include/lldb/Interpreter/OptionValueArch.h<br>
lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
lldb/include/lldb/Interpreter/OptionValueChar.h<br>
lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
lldb/include/lldb/Interpreter/OptionValueRegex.h<br>
lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
lldb/include/lldb/Interpreter/OptionValueString.h<br>
lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
lldb/include/lldb/Interpreter/Options.h<br>
lldb/source/Interpreter/CommandAlias.cpp<br>
lldb/source/Interpreter/CommandInterpreter.cpp<br>
lldb/source/Interpreter/CommandObject.cpp<br>
lldb/source/Interpreter/OptionGroupFile.cpp<br>
lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
lldb/source/Interpreter/OptionGroupVariable.cpp<br>
lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
lldb/source/Interpreter/OptionValueFileColonLine.cpp<br>
lldb/source/Interpreter/OptionValueFileSpec.cpp<br>
lldb/source/Interpreter/OptionValueFormatEntity.cpp<br>
lldb/source/Interpreter/OptionValueProperties.cpp<br>
lldb/source/Interpreter/Options.cpp<br>
lldb/source/Interpreter/Property.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/lldb/include/lldb/Interpreter/OptionGroupPlatform.h b/lldb/include/lldb/Interpreter/OptionGroupPlatform.h<br>
index 99945e5246fd..fed2791a6130 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionGroupPlatform.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionGroupPlatform.h<br>
@@ -21,8 +21,7 @@ namespace lldb_private {<br>
class OptionGroupPlatform : public OptionGroup {<br>
public:<br>
OptionGroupPlatform(bool include_platform_option)<br>
- : OptionGroup(), m_platform_name(), m_sdk_sysroot(),<br>
- m_include_platform_option(include_platform_option) {}<br>
+ : m_include_platform_option(include_platform_option) {}<br>
<br>
~OptionGroupPlatform() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueArch.h b/lldb/include/lldb/Interpreter/OptionValueArch.h<br>
index d079b3896531..22f75a6259c5 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueArch.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueArch.h<br>
@@ -19,17 +19,15 @@ class OptionValueArch : public OptionValue {<br>
public:<br>
OptionValueArch() = default;<br>
<br>
- OptionValueArch(const char *triple)<br>
- : OptionValue(), m_current_value(triple), m_default_value() {<br>
+ OptionValueArch(const char *triple) : m_current_value(triple) {<br>
m_default_value = m_current_value;<br>
}<br>
<br>
OptionValueArch(const ArchSpec &value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
<br>
OptionValueArch(const ArchSpec ¤t_value, const ArchSpec &default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
~OptionValueArch() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueBoolean.h b/lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
index d0eb4362d466..6ae464bd8fb2 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueBoolean.h<br>
@@ -16,10 +16,9 @@ namespace lldb_private {<br>
class OptionValueBoolean : public OptionValue {<br>
public:<br>
OptionValueBoolean(bool value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
OptionValueBoolean(bool current_value, bool default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
~OptionValueBoolean() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueChar.h b/lldb/include/lldb/Interpreter/OptionValueChar.h<br>
index f3fd28104067..78f91df99842 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueChar.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueChar.h<br>
@@ -16,11 +16,10 @@ namespace lldb_private {<br>
class OptionValueChar : public OptionValue {<br>
public:<br>
OptionValueChar(char value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
<br>
OptionValueChar(char current_value, char default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
~OptionValueChar() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueDictionary.h b/lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
index e645f32cb800..f1538983b50b 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueDictionary.h<br>
@@ -19,8 +19,7 @@ class OptionValueDictionary : public OptionValue {<br>
public:<br>
OptionValueDictionary(uint32_t type_mask = UINT32_MAX,<br>
bool raw_value_dump = true)<br>
- : OptionValue(), m_type_mask(type_mask), m_values(),<br>
- m_raw_value_dump(raw_value_dump) {}<br>
+ : m_type_mask(type_mask), m_raw_value_dump(raw_value_dump) {}<br>
<br>
~OptionValueDictionary() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h b/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
index b2dc11b7745a..73c8058402e3 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h<br>
@@ -21,7 +21,7 @@ class OptionValueFileSpecList : public OptionValue {<br>
OptionValueFileSpecList() = default;<br>
<br>
OptionValueFileSpecList(const FileSpecList ¤t_value)<br>
- : OptionValue(), m_current_value(current_value) {}<br>
+ : m_current_value(current_value) {}<br>
<br>
~OptionValueFileSpecList() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueFormat.h b/lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
index eb80f09bb092..aa5ec591a533 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueFormat.h<br>
@@ -16,11 +16,10 @@ namespace lldb_private {<br>
class OptionValueFormat : public OptionValue {<br>
public:<br>
OptionValueFormat(lldb::Format value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
<br>
OptionValueFormat(lldb::Format current_value, lldb::Format default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
~OptionValueFormat() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueLanguage.h b/lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
index bfe953a53c98..44f5eaab9b42 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueLanguage.h<br>
@@ -18,12 +18,11 @@ namespace lldb_private {<br>
class OptionValueLanguage : public OptionValue {<br>
public:<br>
OptionValueLanguage(lldb::LanguageType value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
<br>
OptionValueLanguage(lldb::LanguageType current_value,<br>
lldb::LanguageType default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
~OptionValueLanguage() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValuePathMappings.h b/lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
index e8af4bb23535..3f23246634f5 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValuePathMappings.h<br>
@@ -17,7 +17,7 @@ namespace lldb_private {<br>
class OptionValuePathMappings : public OptionValue {<br>
public:<br>
OptionValuePathMappings(bool notify_changes)<br>
- : OptionValue(), m_path_mappings(), m_notify_changes(notify_changes) {}<br>
+ : m_notify_changes(notify_changes) {}<br>
<br>
~OptionValuePathMappings() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueRegex.h b/lldb/include/lldb/Interpreter/OptionValueRegex.h<br>
index d8589581e51a..fbfb789301e8 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueRegex.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueRegex.h<br>
@@ -17,7 +17,7 @@ namespace lldb_private {<br>
class OptionValueRegex : public OptionValue {<br>
public:<br>
OptionValueRegex(const char *value = nullptr)<br>
- : OptionValue(), m_regex(llvm::StringRef::withNullAsEmpty(value)),<br>
+ : m_regex(llvm::StringRef::withNullAsEmpty(value)),<br>
m_default_regex_str(llvm::StringRef::withNullAsEmpty(value).str()) {}<br>
<br>
~OptionValueRegex() override = default;<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueSInt64.h b/lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
index 625193f87583..54295cb724ff 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueSInt64.h<br>
@@ -19,13 +19,10 @@ class OptionValueSInt64 : public OptionValue {<br>
OptionValueSInt64() = default;<br>
<br>
OptionValueSInt64(int64_t value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value),<br>
- m_min_value(INT64_MIN), m_max_value(INT64_MAX) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
<br>
OptionValueSInt64(int64_t current_value, int64_t default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value), m_min_value(INT64_MIN),<br>
- m_max_value(INT64_MAX) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
OptionValueSInt64(const OptionValueSInt64 &rhs) = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueString.h b/lldb/include/lldb/Interpreter/OptionValueString.h<br>
index 4d78cbb64e5a..948eef7fe4e9 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueString.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueString.h<br>
@@ -26,21 +26,16 @@ class OptionValueString : public OptionValue {<br>
OptionValueString() = default;<br>
<br>
OptionValueString(ValidatorCallback validator, void *baton = nullptr)<br>
- : OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
- m_validator(validator), m_validator_baton(baton) {}<br>
+ : m_validator(validator), m_validator_baton(baton) {}<br>
<br>
- OptionValueString(const char *value)<br>
- : OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
- m_validator(), m_validator_baton() {<br>
+ OptionValueString(const char *value) {<br>
if (value && value[0]) {<br>
m_current_value.assign(value);<br>
m_default_value.assign(value);<br>
}<br>
}<br>
<br>
- OptionValueString(const char *current_value, const char *default_value)<br>
- : OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
- m_validator(), m_validator_baton() {<br>
+ OptionValueString(const char *current_value, const char *default_value) {<br>
if (current_value && current_value[0])<br>
m_current_value.assign(current_value);<br>
if (default_value && default_value[0])<br>
@@ -49,8 +44,7 @@ class OptionValueString : public OptionValue {<br>
<br>
OptionValueString(const char *value, ValidatorCallback validator,<br>
void *baton = nullptr)<br>
- : OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
- m_validator(validator), m_validator_baton(baton) {<br>
+ : m_validator(validator), m_validator_baton(baton) {<br>
if (value && value[0]) {<br>
m_current_value.assign(value);<br>
m_default_value.assign(value);<br>
@@ -59,8 +53,7 @@ class OptionValueString : public OptionValue {<br>
<br>
OptionValueString(const char *current_value, const char *default_value,<br>
ValidatorCallback validator, void *baton = nullptr)<br>
- : OptionValue(), m_current_value(), m_default_value(), m_options(),<br>
- m_validator(validator), m_validator_baton(baton) {<br>
+ : m_validator(validator), m_validator_baton(baton) {<br>
if (current_value && current_value[0])<br>
m_current_value.assign(current_value);<br>
if (default_value && default_value[0])<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueUInt64.h b/lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
index bee8ff5117a9..bc21b1a2a89c 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueUInt64.h<br>
@@ -19,11 +19,10 @@ class OptionValueUInt64 : public OptionValue {<br>
OptionValueUInt64() = default;<br>
<br>
OptionValueUInt64(uint64_t value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value) {}<br>
+ : m_current_value(value), m_default_value(value) {}<br>
<br>
OptionValueUInt64(uint64_t current_value, uint64_t default_value)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value) {}<br>
+ : m_current_value(current_value), m_default_value(default_value) {}<br>
<br>
~OptionValueUInt64() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/OptionValueUUID.h b/lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
index 1673078344f5..2d1d8bdeba61 100644<br>
--- a/lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
+++ b/lldb/include/lldb/Interpreter/OptionValueUUID.h<br>
@@ -18,7 +18,7 @@ class OptionValueUUID : public OptionValue {<br>
public:<br>
OptionValueUUID() = default;<br>
<br>
- OptionValueUUID(const UUID &uuid) : OptionValue(), m_uuid(uuid) {}<br>
+ OptionValueUUID(const UUID &uuid) : m_uuid(uuid) {}<br>
<br>
~OptionValueUUID() override = default;<br>
<br>
<br>
diff --git a/lldb/include/lldb/Interpreter/Options.h b/lldb/include/lldb/Interpreter/Options.h<br>
index 9738cce2f7a1..0d86fac14dcc 100644<br>
--- a/lldb/include/lldb/Interpreter/Options.h<br>
+++ b/lldb/include/lldb/Interpreter/Options.h<br>
@@ -254,8 +254,7 @@ class OptionGroup {<br>
<br>
class OptionGroupOptions : public Options {<br>
public:<br>
- OptionGroupOptions()<br>
- : Options(), m_option_defs(), m_option_infos(), m_did_finalize(false) {}<br>
+ OptionGroupOptions() : m_did_finalize(false) {}<br>
<br>
~OptionGroupOptions() override = default;<br>
<br>
<br>
diff --git a/lldb/source/Interpreter/CommandAlias.cpp b/lldb/source/Interpreter/CommandAlias.cpp<br>
index a5e033937210..f0f577bf0585 100644<br>
--- a/lldb/source/Interpreter/CommandAlias.cpp<br>
+++ b/lldb/source/Interpreter/CommandAlias.cpp<br>
@@ -80,7 +80,7 @@ CommandAlias::CommandAlias(CommandInterpreter &interpreter,<br>
llvm::StringRef help, llvm::StringRef syntax,<br>
uint32_t flags)<br>
: CommandObject(interpreter, name, help, syntax, flags),<br>
- m_underlying_command_sp(), m_option_string(std::string(options_args)),<br>
+ m_option_string(std::string(options_args)),<br>
m_option_args_sp(new OptionArgVector),<br>
m_is_dashdash_alias(eLazyBoolCalculate), m_did_set_help(false),<br>
m_did_set_help_long(false) {<br>
<br>
diff --git a/lldb/source/Interpreter/CommandInterpreter.cpp b/lldb/source/Interpreter/CommandInterpreter.cpp<br>
index f0a6baa3b9ad..b0ff634f0365 100644<br>
--- a/lldb/source/Interpreter/CommandInterpreter.cpp<br>
+++ b/lldb/source/Interpreter/CommandInterpreter.cpp<br>
@@ -122,9 +122,8 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger,<br>
IOHandlerDelegate(IOHandlerDelegate::Completion::LLDBCommand),<br>
m_debugger(debugger), m_synchronous_execution(true),<br>
m_skip_lldbinit_files(false), m_skip_app_init_files(false),<br>
- m_command_io_handler_sp(), m_comment_char('#'),<br>
- m_batch_command_mode(false), m_truncation_warning(eNoTruncation),<br>
- m_command_source_depth(0), m_result(), m_transcript_stream() {<br>
+ m_comment_char('#'), m_batch_command_mode(false),<br>
+ m_truncation_warning(eNoTruncation), m_command_source_depth(0) {<br>
SetEventName(eBroadcastBitThreadShouldExit, "thread-should-exit");<br>
SetEventName(eBroadcastBitResetPrompt, "reset-prompt");<br>
SetEventName(eBroadcastBitQuitCommandReceived, "quit");<br>
<br>
diff --git a/lldb/source/Interpreter/CommandObject.cpp b/lldb/source/Interpreter/CommandObject.cpp<br>
index 9d27de46e382..22effff9bf44 100644<br>
--- a/lldb/source/Interpreter/CommandObject.cpp<br>
+++ b/lldb/source/Interpreter/CommandObject.cpp<br>
@@ -42,8 +42,7 @@ CommandObject::CommandObject(CommandInterpreter &interpreter,<br>
llvm::StringRef name, llvm::StringRef help,<br>
llvm::StringRef syntax, uint32_t flags)<br>
: m_interpreter(interpreter), m_cmd_name(std::string(name)),<br>
- m_cmd_help_short(), m_cmd_help_long(), m_cmd_syntax(), m_flags(flags),<br>
- m_arguments(), m_deprecated_command_override_callback(nullptr),<br>
+ m_flags(flags), m_deprecated_command_override_callback(nullptr),<br>
m_command_override_callback(nullptr), m_command_override_baton(nullptr) {<br>
m_cmd_help_short = std::string(help);<br>
m_cmd_syntax = std::string(syntax);<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupFile.cpp b/lldb/source/Interpreter/OptionGroupFile.cpp<br>
index 8be4b18a2134..25f3a9b9e3fe 100644<br>
--- a/lldb/source/Interpreter/OptionGroupFile.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupFile.cpp<br>
@@ -17,8 +17,7 @@ OptionGroupFile::OptionGroupFile(uint32_t usage_mask, bool required,<br>
const char *long_option, int short_option,<br>
uint32_t completion_type,<br>
lldb::CommandArgumentType argument_type,<br>
- const char *usage_text)<br>
- : m_file() {<br>
+ const char *usage_text) {<br>
m_option_definition.usage_mask = usage_mask;<br>
m_option_definition.required = required;<br>
m_option_definition.long_option = long_option;<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupOutputFile.cpp b/lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
index 1f3050834ec3..6a626bd63014 100644<br>
--- a/lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupOutputFile.cpp<br>
@@ -13,8 +13,7 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-OptionGroupOutputFile::OptionGroupOutputFile()<br>
- : m_file(), m_append(false, false) {}<br>
+OptionGroupOutputFile::OptionGroupOutputFile() : m_append(false, false) {}<br>
<br>
static const uint32_t SHORT_OPTION_APND = 0x61706e64; // 'apnd'<br>
<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp b/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
index e768febebb89..654cc8f9cc57 100644<br>
--- a/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp<br>
@@ -18,7 +18,7 @@ OptionGroupPythonClassWithDict::OptionGroupPythonClassWithDict<br>
bool is_class,<br>
int class_option,<br>
int key_option, <br>
- int value_option) : OptionGroup(), m_is_class(is_class) {<br>
+ int value_option) : m_is_class(is_class) {<br>
m_key_usage_text.assign("The key for a key/value pair passed to the "<br>
"implementation of a ");<br>
m_key_usage_text.append(class_use);<br>
<br>
diff --git a/lldb/source/Interpreter/OptionGroupVariable.cpp b/lldb/source/Interpreter/OptionGroupVariable.cpp<br>
index 2451a3e96478..20a521b8e44f 100644<br>
--- a/lldb/source/Interpreter/OptionGroupVariable.cpp<br>
+++ b/lldb/source/Interpreter/OptionGroupVariable.cpp<br>
@@ -67,8 +67,8 @@ static Status ValidateSummaryString(const char *str, void *) {<br>
}<br>
<br>
OptionGroupVariable::OptionGroupVariable(bool show_frame_options)<br>
- : OptionGroup(), include_frame_options(show_frame_options),<br>
- summary(ValidateNamedSummary), summary_string(ValidateSummaryString) {}<br>
+ : include_frame_options(show_frame_options), summary(ValidateNamedSummary),<br>
+ summary_string(ValidateSummaryString) {}<br>
<br>
Status<br>
OptionGroupVariable::SetOptionValue(uint32_t option_idx,<br>
<br>
diff --git a/lldb/source/Interpreter/OptionValueEnumeration.cpp b/lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
index 8fcd8db1ee96..d216a5c5218d 100644<br>
--- a/lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
+++ b/lldb/source/Interpreter/OptionValueEnumeration.cpp<br>
@@ -15,8 +15,7 @@ using namespace lldb_private;<br>
<br>
OptionValueEnumeration::OptionValueEnumeration(<br>
const OptionEnumValues &enumerators, enum_type value)<br>
- : OptionValue(), m_current_value(value), m_default_value(value),<br>
- m_enumerations() {<br>
+ : m_current_value(value), m_default_value(value) {<br>
SetEnumerations(enumerators);<br>
}<br>
<br>
<br>
diff --git a/lldb/source/Interpreter/OptionValueFileColonLine.cpp b/lldb/source/Interpreter/OptionValueFileColonLine.cpp<br>
index dac557c4248a..6d5d82d9ed3b 100644<br>
--- a/lldb/source/Interpreter/OptionValueFileColonLine.cpp<br>
+++ b/lldb/source/Interpreter/OptionValueFileColonLine.cpp<br>
@@ -22,12 +22,12 @@ using namespace lldb_private;<br>
// only usefully complete in the file name part of it so it should be good<br>
// enough.<br>
OptionValueFileColonLine::OptionValueFileColonLine()<br>
- : OptionValue(), m_file_spec(), m_line_number(LLDB_INVALID_LINE_NUMBER),<br>
+ : m_line_number(LLDB_INVALID_LINE_NUMBER),<br>
m_column_number(LLDB_INVALID_COLUMN_NUMBER),<br>
m_completion_mask(CommandCompletions::eSourceFileCompletion) {}<br>
<br>
OptionValueFileColonLine::OptionValueFileColonLine(llvm::StringRef input)<br>
- : OptionValue(), m_file_spec(), m_line_number(LLDB_INVALID_LINE_NUMBER),<br>
+ : m_line_number(LLDB_INVALID_LINE_NUMBER),<br>
m_column_number(LLDB_INVALID_COLUMN_NUMBER),<br>
m_completion_mask(CommandCompletions::eSourceFileCompletion) {<br>
SetValueFromString(input, eVarSetOperationAssign);<br>
<br>
diff --git a/lldb/source/Interpreter/OptionValueFileSpec.cpp b/lldb/source/Interpreter/OptionValueFileSpec.cpp<br>
index a03fd55d0385..8d43371f8674 100644<br>
--- a/lldb/source/Interpreter/OptionValueFileSpec.cpp<br>
+++ b/lldb/source/Interpreter/OptionValueFileSpec.cpp<br>
@@ -19,22 +19,18 @@ using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
OptionValueFileSpec::OptionValueFileSpec(bool resolve)<br>
- : OptionValue(), m_current_value(), m_default_value(), m_data_sp(),<br>
- m_data_mod_time(),<br>
- m_completion_mask(CommandCompletions::eDiskFileCompletion),<br>
+ : m_completion_mask(CommandCompletions::eDiskFileCompletion),<br>
m_resolve(resolve) {}<br>
<br>
OptionValueFileSpec::OptionValueFileSpec(const FileSpec &value, bool resolve)<br>
- : OptionValue(), m_current_value(value), m_default_value(value),<br>
- m_data_sp(), m_data_mod_time(),<br>
+ : m_current_value(value), m_default_value(value),<br>
m_completion_mask(CommandCompletions::eDiskFileCompletion),<br>
m_resolve(resolve) {}<br>
<br>
OptionValueFileSpec::OptionValueFileSpec(const FileSpec ¤t_value,<br>
const FileSpec &default_value,<br>
bool resolve)<br>
- : OptionValue(), m_current_value(current_value),<br>
- m_default_value(default_value), m_data_sp(), m_data_mod_time(),<br>
+ : m_current_value(current_value), m_default_value(default_value),<br>
m_completion_mask(CommandCompletions::eDiskFileCompletion),<br>
m_resolve(resolve) {}<br>
<br>
<br>
diff --git a/lldb/source/Interpreter/OptionValueFormatEntity.cpp b/lldb/source/Interpreter/OptionValueFormatEntity.cpp<br>
index 509a21752e48..00d58922f950 100644<br>
--- a/lldb/source/Interpreter/OptionValueFormatEntity.cpp<br>
+++ b/lldb/source/Interpreter/OptionValueFormatEntity.cpp<br>
@@ -15,9 +15,7 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-OptionValueFormatEntity::OptionValueFormatEntity(const char *default_format)<br>
- : OptionValue(), m_current_format(), m_default_format(), m_current_entry(),<br>
- m_default_entry() {<br>
+OptionValueFormatEntity::OptionValueFormatEntity(const char *default_format) {<br>
if (default_format && default_format[0]) {<br>
llvm::StringRef default_format_str(default_format);<br>
Status error = FormatEntity::Parse(default_format_str, m_default_entry);<br>
<br>
diff --git a/lldb/source/Interpreter/OptionValueProperties.cpp b/lldb/source/Interpreter/OptionValueProperties.cpp<br>
index 6c4e77f614f9..22447a82d811 100644<br>
--- a/lldb/source/Interpreter/OptionValueProperties.cpp<br>
+++ b/lldb/source/Interpreter/OptionValueProperties.cpp<br>
@@ -20,13 +20,11 @@<br>
using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
-OptionValueProperties::OptionValueProperties(ConstString name)<br>
- : OptionValue(), m_name(name), m_properties(), m_name_to_index() {}<br>
+OptionValueProperties::OptionValueProperties(ConstString name) : m_name(name) {}<br>
<br>
OptionValueProperties::OptionValueProperties(<br>
const OptionValueProperties &global_properties)<br>
: OptionValue(global_properties),<br>
- std::enable_shared_from_this<OptionValueProperties>(),<br>
m_name(global_properties.m_name),<br>
m_properties(global_properties.m_properties),<br>
m_name_to_index(global_properties.m_name_to_index) {<br>
<br>
diff --git a/lldb/source/Interpreter/Options.cpp b/lldb/source/Interpreter/Options.cpp<br>
index 5d3864dbfff3..f39ef20af4f8 100644<br>
--- a/lldb/source/Interpreter/Options.cpp<br>
+++ b/lldb/source/Interpreter/Options.cpp<br>
@@ -25,7 +25,7 @@ using namespace lldb;<br>
using namespace lldb_private;<br>
<br>
// Options<br>
-Options::Options() : m_getopt_table() { BuildValidOptionSets(); }<br>
+Options::Options() { BuildValidOptionSets(); }<br>
<br>
Options::~Options() = default;<br>
<br>
<br>
diff --git a/lldb/source/Interpreter/Property.cpp b/lldb/source/Interpreter/Property.cpp<br>
index a02497662ff5..55400a2bc42d 100644<br>
--- a/lldb/source/Interpreter/Property.cpp<br>
+++ b/lldb/source/Interpreter/Property.cpp<br>
@@ -22,7 +22,7 @@ using namespace lldb_private;<br>
<br>
Property::Property(const PropertyDefinition &definition)<br>
: m_name(<a href="http://definition.name" rel="noreferrer" target="_blank">definition.name</a>), m_description(definition.description),<br>
- m_value_sp(), m_is_global(definition.global) {<br>
+ m_is_global(definition.global) {<br>
switch (definition.type) {<br>
case OptionValue::eTypeInvalid:<br>
case OptionValue::eTypeProperties:<br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>