<div dir="ltr"><a class="gmail_plusreply" id="plusReplyChip-0" href="mailto:rupprecht@google.com" tabindex="-1">+Jordan Rupprecht</a> <div><br></div><div>Interesting, we were using this internally to point to an lldb-server to test. I've disabled some tests at the moment, but I'm not sure it isn't entirely useful functionality :)</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 19, 2021 at 5:01 AM Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Pavel Labath<br>
Date: 2021-01-19T11:01:07+01:00<br>
New Revision: 079e664661770a78e30c0d27a12d50047f1b1ea8<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8.diff</a><br>
<br>
LOG: [lldb] Re-enable TestPlatformProcessConnect on macos<br>
<br>
The test couldn't find lldb-server as it's path was being overridden by<br>
LLDB_DEBUGSERVER_PATH environment variable (pointing to debugserver).<br>
This test should always use lldb-server, as it tests its platform<br>
capabilities.<br>
<br>
There's no need for the environment override, as lldb-server tests<br>
should test the executable they just built, so I just remote the<br>
override capability.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py<br>
lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py<br>
index 07136108b2a4..d16549420a14 100644<br>
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py<br>
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py<br>
@@ -72,9 +72,6 @@ def get_lldb_server_exe():<br>
A path to the lldb-server exe if it is found to exist; otherwise,<br>
returns None.<br>
"""<br>
- if "LLDB_DEBUGSERVER_PATH" in os.environ:<br>
- return os.environ["LLDB_DEBUGSERVER_PATH"]<br>
-<br>
return _get_debug_monitor_from_lldb(<br>
lldbtest_config.lldbExec, "lldb-server")<br>
<br>
<br>
diff --git a/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py b/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py<br>
index 8ddab260b494..3607c49c9c97 100644<br>
--- a/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py<br>
+++ b/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py<br>
@@ -11,7 +11,6 @@ class TestPlatformProcessConnect(gdbremote_testcase.GdbRemoteTestCaseBase):<br>
@skipIfRemote<br>
@expectedFailureAll(hostoslist=["windows"], triple='.*-android')<br>
@skipIfWindows # lldb-server does not terminate correctly<br>
- @skipIfDarwin # lldb-server not found correctly<br>
def test_platform_process_connect(self):<br>
self.build()<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>