<div dir="auto">I'll revert this patch. This seems to be the reason</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il Mer 24 Giu 2020, 6:27 AM Florian Hahn via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank" rel="noreferrer">reviews@reviews.llvm.org</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">fhahn added a comment.<br>
<br>
I noticed that it appears that ` lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed it failing spuriously relatively frequently<br>
<br>
For example <a href="http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5519" rel="noreferrer noreferrer noreferrer" target="_blank">http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5519</a> failed with<br>
<br>
FAIL: lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py (825 of 2068)<br>
******************** TEST 'lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py' FAILED ********************<br>
Script:<br>
--<br>
/usr/bin/python3.6 /home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/test/API/dotest.py --arch aarch64 -s /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-traces -S nm -u CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy --env LLVM_LIBS_DIR=/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./lib --build-dir /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/lldb --compiler /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/clang --dsymutil /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/dsymutil --filecheck /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/FileCheck --lldb-libs-dir /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./lib /home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/test/API/tools/lldb-vscode/attach -p TestVSCode_attach.py<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stdout):<br>
--<br>
lldb version 11.0.0<br>
clang revision 72131423cc952ccbd6d8e021ff7c04fa22297fe3<br>
llvm revision 72131423cc952ccbd6d8e021ff7c04fa22297fe3<br>
LLDB library dir: /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin<br>
LLDB import library dir: /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./lib<br>
Libc++ tests will not be run because: Compiling with -stdlib=libc++ fails with the error: <stdin>:1:10: fatal error: 'algorithm' file not found<br>
#include <algorithm><br>
^~~~~~~~~~~<br>
1 error generated.<br>
<br>
Skipping following debug info categories: ['dsym', 'gmodules']<br>
description: breakpoint 1.1<br>
description: breakpoint 1.1<br>
<br>
--<br>
Command Output (stderr):<br>
--<br>
<br>
Session logs for test failures/errors/unexpected successes will go into directory '/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-traces'<br>
PASS: LLDB (/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: test_by_name (TestVSCode_attach.TestVSCode_attach)<br>
UNSUPPORTED: LLDB (/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: test_by_name_waitFor (TestVSCode_attach.TestVSCode_attach) (requires one of darwin, macosx, ios, watchos, tvos, bridgeos) <br>
PASS: LLDB (/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: test_by_pid (TestVSCode_attach.TestVSCode_attach)<br>
FAIL: LLDB (/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: test_commands (TestVSCode_attach.TestVSCode_attach)<br>
CLEANUP ERROR: LLDB (/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: test_commands (TestVSCode_attach.TestVSCode_attach)<br>
PASS: LLDB (/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: test_terminate_commands (TestVSCode_attach.TestVSCode_attach)<br>
======================================================================<br>
FAIL: test_commands (TestVSCode_attach.TestVSCode_attach)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py", line 174, in test_commands<br>
self.continue_to_breakpoints(breakpoint_ids)<br>
File "/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py", line 226, in continue_to_breakpoints<br>
self.verify_breakpoint_hit(breakpoint_ids)<br>
File "/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py", line 85, in verify_breakpoint_hit<br>
self.assertTrue(False, "breakpoint not hit")<br>
AssertionError: False is not True : breakpoint not hit<br>
Config=aarch64-/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11<br>
----------------------------------------------------------------------<br>
Ran 5 tests in 27.063s<br>
<br>
RESULT: FAILED (3 passes, 1 failures, 0 errors, 1 skipped, 0 expected failures, 0 unexpected successes)<br>
<br>
--<br>
<br>
Not sure if the failure is related to this patch, but it appears to be the most recent change.<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D81978/new/" rel="noreferrer noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D81978/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D81978" rel="noreferrer noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D81978</a><br>
<br>
<br>
<br>
</blockquote></div>