<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Sorry I missed that. That seems fine. In the dedicated REPL, you’re probably dead at this point, but you can do “expr —repl --” in which case we’ll pick whatever thread on to run your expression, adding the results to the REPL context, so it could happen there and you might not be all the way toast. So just returning an error is fine.<div class=""><div><br class=""></div><div>Jim</div><div><br class=""><blockquote type="cite" class=""><div class="">On May 21, 2020, at 11:23 PM, Jonas Devlieghere <<a href="mailto:jonas@devlieghere.com" class="">jonas@devlieghere.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Jim, does this look correct to you?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 21, 2020 at 11:22 PM Jonas Devlieghere via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br class="">
Author: Jonas Devlieghere<br class="">
Date: 2020-05-21T23:22:17-07:00<br class="">
New Revision: 8a6333ef38088b65224bc021a14eeeef0a123a29<br class="">
<br class="">
URL: <a href="https://github.com/llvm/llvm-project/commit/8a6333ef38088b65224bc021a14eeeef0a123a29" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/commit/8a6333ef38088b65224bc021a14eeeef0a123a29</a><br class="">
DIFF: <a href="https://github.com/llvm/llvm-project/commit/8a6333ef38088b65224bc021a14eeeef0a123a29.diff" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/commit/8a6333ef38088b65224bc021a14eeeef0a123a29.diff</a><br class="">
<br class="">
LOG: [lldb/REPL] Fix unhandled switch case<br class="">
<br class="">
Fix warning: enumeration value 'eExpressionThreadVanished' not handled<br class="">
in switch [-Wswitch]<br class="">
<br class="">
Added: <br class="">
<br class="">
<br class="">
Modified: <br class="">
lldb/source/Expression/REPL.cpp<br class="">
<br class="">
Removed: <br class="">
<br class="">
<br class="">
<br class="">
################################################################################<br class="">
diff --git a/lldb/source/Expression/REPL.cpp b/lldb/source/Expression/REPL.cpp<br class="">
index 6c9792c6e837..a55fe09bdeb6 100644<br class="">
--- a/lldb/source/Expression/REPL.cpp<br class="">
+++ b/lldb/source/Expression/REPL.cpp<br class="">
@@ -388,6 +388,11 @@ void REPL::IOHandlerInputComplete(IOHandler &io_handler, std::string &code) {<br class="">
error_sp->Printf("error: stopped for debug -- %s\n",<br class="">
error.AsCString());<br class="">
break;<br class="">
+ case lldb::eExpressionThreadVanished:<br class="">
+ // Shoulnd't happen???<br class="">
+ error_sp->Printf("error: expression thread vanished -- %s\n",<br class="">
+ error.AsCString());<br class="">
+ break;<br class="">
}<br class="">
}<br class="">
<br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>