<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hey Jason,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Sorry, I think I ended up accidentally dropping the verification in the final version (<a href="https://github.com/llvm/llvm-project/blob/b1b70f6761266c3eecaf8bd71529eaf51994207b/lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp#L307">https://github.com/llvm/llvm-project/blob/b1b70f6761266c3eecaf8bd71529eaf51994207b/lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp#L307</a>). I had implemented GDBRemoteCommunicationClient::GetgPacketSupported previously, though (<a href="https://reviews.llvm.org/D62931?id=226779">https://reviews.llvm.org/D62931?id=226779</a>). So maybe we could just hook that up again? I.e., read_all_registers_at_once = !pSupported || (gdb_process->m_use_g_packet_for_reading && gSupported).</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thanks!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 8, 2019 at 7:15 PM Jason Molenda <<a href="mailto:jmolenda@apple.com">jmolenda@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">A heads-up - lldb is failing to detect the case where the remote gdb RSP stub does not support the 'g' packet.  I found this while doing some bare board debugging; g fails and doesn't fall back to fetching register values individually.  <br>
<br>
I wrote a test TestNoGPacketSupported.py to show this behavior - it's currently marked as @expectedFailureAll.  If I add the plugin.process.gdb-remote.use-g-packet-for-reading = false setting, the test case passes, but of course we can't require people to use that.  lldb has to be adaptive to the packets that the remote stub supports.<br>
<br>
<br>
I'll try to look at the updating the changes to work correctly in this environment, but I wanted to raise the issue more widely in case anyone has a chance before me. <br>
<br>
<br>
J<br>
<br>
<br>
> On Oct 30, 2019, at 9:30 AM, Guilherme Andrade via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br>
> <br>
> guiandrade added a comment.<br>
> <br>
> In D62931#1726865 <<a href="https://reviews.llvm.org/D62931#1726865" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62931#1726865</a>>, @labath wrote:<br>
> <br>
>> This looks fine to me. Thanks for your patience. Do you still need someone to commit this for you?<br>
> <br>
> <br>
> Np. Yes, I do. Could you please do it for me?<br>
> <br>
> Thanks!<br>
> <br>
> <br>
> Repository:<br>
>  rG LLVM Github Monorepo<br>
> <br>
> CHANGES SINCE LAST ACTION<br>
>  <a href="https://reviews.llvm.org/D62931/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62931/new/</a><br>
> <br>
> <a href="https://reviews.llvm.org/D62931" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62931</a><br>
> <br>
> <br>
> <br>
<br>
</blockquote></div><br clear="all"><div><br></div>--<div dir="ltr" class="gmail_signature"><div dir="ltr"><div style="line-height:1.5em;padding-top:10px;margin-top:10px;color:rgb(85,85,85);font-family:sans-serif"><span style="border-width:2px 0px 0px;border-style:solid;border-color:rgb(238,178,17);padding-top:2px;margin-top:2px"></span></div></div></div></div>