<div dir="ltr">Does disabling tests really quality a patch for the [NFC] label?<div><br></div><div>Are these buggy tests or is there something that makes the actually not relevant on Windows?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 3, 2019 at 9:20 AM Raphael Isemann via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: teemperor<br>
Date: Tue Sep  3 09:21:57 2019<br>
New Revision: 370776<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=370776&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=370776&view=rev</a><br>
Log:<br>
[lldb][NFC] Disable added frame select and all log option test on windows<br>
<br>
Modified:<br>
    lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py<br>
    lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py?rev=370776&r1=370775&r2=370776&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py?rev=370776&r1=370775&r2=370776&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFrameSelect.py Tue Sep  3 09:21:57 2019<br>
@@ -11,6 +11,7 @@ class TestFrameSelect(TestBase):<br>
     mydir = TestBase.compute_mydir(__file__)<br>
<br>
     @no_debug_info_test<br>
+    @skipIfWindows<br>
     def test_relative(self):<br>
         self.build()<br>
<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py?rev=370776&r1=370775&r2=370776&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py?rev=370776&r1=370775&r2=370776&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py Tue Sep  3 09:21:57 2019<br>
@@ -91,6 +91,7 @@ class LogTestCase(TestBase):<br>
         self.assertEquals(contents.find("bacon"), 0)<br>
<br>
     # Enable all log options and check that nothing crashes.<br>
+    @skipIfWindows<br>
     def test_all_log_options(self):<br>
         if (os.path.exists(self.log_file)):<br>
             os.remove(self.log_file)<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>