<div dir="ltr"><div>When you run the tests without multiprocessing, lldb's output is not redirected. So the logic correctly detects that colors are supported, leading to potential test failures under this mode. <br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 17, 2019 at 11:42 AM Adrian McCarthy <<a href="mailto:amccarth@google.com">amccarth@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">I thought the color code was smart enough to figure out whether it was actually going to an actual terminal or being redirected.  Is this hiding a bug in that logic?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 17, 2019 at 10:56 AM Jonas Devlieghere via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: jdevlieghere<br>
Date: Wed Jul 17 10:56:57 2019<br>
New Revision: 366356<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=366356&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=366356&view=rev</a><br>
Log:<br>
[dotest] Disable color while testing.<br>
<br>
Disable colors so we don't risk having unexpected ANSI codes in the test<br>
output. Currently, the behavior of a test can change depending on<br>
whether it's run under a color-supporting terminal, or under a dummy<br>
terminal, for example when using lit or multiprocessing.<br>
<br>
Modified:<br>
    lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=366356&r1=366355&r2=366356&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=366356&r1=366355&r2=366356&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Wed Jul 17 10:56:57 2019<br>
@@ -1869,6 +1869,9 @@ class TestBase(Base):<br>
         # differ in the debug info, which is not being hashed.<br>
         self.runCmd('settings set symbols.enable-external-lookup false')<br>
<br>
+        # Disable color.<br>
+        self.runCmd("settings set use-color false")<br>
+<br>
         # Make sure that a sanitizer LLDB's environment doesn't get passed on.<br>
         if 'DYLD_LIBRARY_PATH' in os.environ:<br>
             self.runCmd('settings set target.env-vars DYLD_LIBRARY_PATH=')<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</blockquote></div>