<div dir="ltr"><div dir="ltr">Thank you for the comments. Addressed in r365403.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 8, 2019 at 3:40 PM Jim Ingham <<a href="mailto:jingham@apple.com">jingham@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Why is the thread ID getting checked against -1L? Did Windows not define LLDB_INVALID_HOST_THREAD?<br>
<br>
Jim<br>
<br>
> On Jul 8, 2019, at 3:06 PM, Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
> <br>
> Are you sure this will actually produce something meaningful? I know<br>
> llvm usually uses llvm::mapWindowsError for this kind of thing...<br>
> <br>
> On Mon, 8 Jul 2019 at 14:18, Jonas Devlieghere via lldb-commits<br>
> <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
>> <br>
>> Author: jdevlieghere<br>
>> Date: Mon Jul  8 14:19:02 2019<br>
>> New Revision: 365390<br>
>> <br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=365390&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=365390&view=rev</a><br>
>> Log:<br>
>> [Windows] Convert GetLastError to std::error_code<br>
>> <br>
>> Create a std::error_code from the result of GetLastError, which in turn<br>
>> we can use to return an llvm::Error.<br>
>> <br>
>> Modified:<br>
>>    lldb/trunk/source/Host/common/ThreadLauncher.cpp<br>
>> <br>
>> Modified: lldb/trunk/source/Host/common/ThreadLauncher.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/ThreadLauncher.cpp?rev=365390&r1=365389&r2=365390&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/ThreadLauncher.cpp?rev=365390&r1=365389&r2=365390&view=diff</a><br>
>> ==============================================================================<br>
>> --- lldb/trunk/source/Host/common/ThreadLauncher.cpp (original)<br>
>> +++ lldb/trunk/source/Host/common/ThreadLauncher.cpp Mon Jul  8 14:19:02 2019<br>
>> @@ -31,8 +31,10 @@ llvm::Expected<HostThread> ThreadLaunche<br>
>>   thread = (lldb::thread_t)::_beginthreadex(<br>
>>       0, (unsigned)min_stack_byte_size,<br>
>>       HostNativeThread::ThreadCreateTrampoline, info_ptr, 0, NULL);<br>
>> -  if (thread == (lldb::thread_t)(-1L))<br>
>> -    return llvm::errorCodeToError(::GetLastError());<br>
>> +  if (thread == (lldb::thread_t)(-1L)) {<br>
>> +    DWORD err = GetLastError();<br>
>> +    return llvm::errorCodeToError(std::error_code(err, std::system_category()));<br>
>> +  }<br>
>> #else<br>
>> <br>
>> // ASAN instrumentation adds a lot of bookkeeping overhead on stack frames.<br>
>> <br>
>> <br>
>> _______________________________________________<br>
>> lldb-commits mailing list<br>
>> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
<br>
</blockquote></div>