<div dir="ltr">Thanks Pavel! </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 14, 2019 at 1:15 AM Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: labath<br>
Date: Tue May 14 01:18:06 2019<br>
New Revision: 360652<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=360652&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=360652&view=rev</a><br>
Log:<br>
[CMake] Correctly reinstate LLDB_CAN_USE_LLDB_SERVER<br>
<br>
r360631 introduced a "syntax error" which meant that cmake was still not<br>
honoring the value of LLDB_CAN_USE_LLDB_SERVER variable. The correct<br>
syntax for seting an internal cache variable is "set(VAR value CACHE<br>
INTERNAL)", but the patch omitted the "CACHE" keyword. The "syntax<br>
error" is in quotes because without the CACHE keyword this is still<br>
valid syntax for setting the value of LLDB_CAN_USE_LLDB_SERVER to "1<br>
INTERNAL".<br>
<br>
There doesn't seem to be a need for this to be a cache variable so I'm<br>
reverting this variable to a plain one, as it was before r360621.<br>
<br>
This will hopefully fix the windows build.<br>
<br>
Modified:<br>
    lldb/trunk/cmake/modules/LLDBConfig.cmake<br>
<br>
Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=360652&r1=360651&r2=360652&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=360652&r1=360651&r2=360652&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/cmake/modules/LLDBConfig.cmake (original)<br>
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake Tue May 14 01:18:06 2019<br>
@@ -417,9 +417,9 @@ list(APPEND system_libs ${CMAKE_DL_LIBS}<br>
 # Figure out if lldb could use lldb-server.  If so, then we'll<br>
 # ensure we build lldb-server when an lldb target is being built.<br>
 if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|Linux|NetBSD")<br>
-  set(LLDB_CAN_USE_LLDB_SERVER 1 INTERNAL)<br>
+  set(LLDB_CAN_USE_LLDB_SERVER 1)<br>
 else()<br>
-  set(LLDB_CAN_USE_LLDB_SERVER 0 INTERNAL)<br>
+  set(LLDB_CAN_USE_LLDB_SERVER 0)<br>
 endif()<br>
<br>
 # Figure out if lldb could use debugserver.  If so, then we'll<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>