<div dir="ltr"><div dir="ltr">I tried LLVM_ENABLE_PROJECTS=all today, and it fails with<div><br></div><div><div>CMake Error: The following variables are used in this project, but they are set to NOTFOUND.</div><div>Please set them or make sure they are set and tested correctly in the CMake files:</div><div>libedit_INCLUDE_DIRS</div><div> used as include directory in directory /usr/local/google/home/thakis/src/llvm-build-project/CMakeFiles/CMakeTmp</div><div> used as include directory in directory /usr/local/google/home/thakis/src/llvm-build-project/CMakeFiles/CMakeTmp</div><div> used as include directory in directory /usr/local/google/home/thakis/src/llvm-build-project/CMakeFiles/CMakeTmp</div><div>libedit_LIBRARIES</div><div> linked by target "cmTC_43ea9" in directory /usr/local/google/home/thakis/src/llvm-build-project/CMakeFiles/CMakeTmp</div><div><br></div><div>CMake Error at /usr/share/cmake-3.10/Modules/CheckTypeSize.cmake:114 (try_compile):</div><div> Failed to configure test project build system.</div><div>Call Stack (most recent call first):</div><div> /usr/share/cmake-3.10/Modules/CheckTypeSize.cmake:239 (__check_type_size_impl)</div><div> /usr/local/google/home/thakis/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:106 (check_type_size)</div><div> /usr/local/google/home/thakis/src/llvm-project/lldb/CMakeLists.txt:15 (include)</div></div><div><br></div><div><br></div><div><br></div><div>Is that expected?</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 28, 2019 at 11:04 AM Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: labath<br>
Date: Thu Feb 28 08:04:54 2019<br>
New Revision: 355103<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355103&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355103&view=rev</a><br>
Log:<br>
[cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place<br>
<br>
This was previously scattered between the main CMakeLists.txt file and<br>
LLDBGenerateConfig.cmake and LLDBConfig.cmake. This caused the some of<br>
the code to be executed in incorrect order. Specifically, the check for<br>
el_winsertstr was done before libedit_LIBRARIES was computed, and so it<br>
always failed on the first run.<br>
<br>
Moving it the two checks to a central place makes sure this doesn't<br>
happen again and improves the overall readability.<br>
<br>
Modified:<br>
lldb/trunk/CMakeLists.txt<br>
lldb/trunk/cmake/modules/LLDBConfig.cmake<br>
lldb/trunk/cmake/modules/LLDBGenerateConfig.cmake<br>
<br>
Modified: lldb/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=355103&r1=355102&r2=355103&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=355103&r1=355102&r2=355103&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/CMakeLists.txt (original)<br>
+++ lldb/trunk/CMakeLists.txt Thu Feb 28 08:04:54 2019<br>
@@ -22,12 +22,6 @@ else()<br>
add_definitions( -DLLDB_CONFIGURATION_RELEASE )<br>
endif()<br>
<br>
-if (LLDB_DISABLE_LIBEDIT)<br>
- add_definitions( -DLLDB_DISABLE_LIBEDIT )<br>
-else()<br>
- find_package(LibEdit REQUIRED)<br>
-endif()<br>
-<br>
if(APPLE)<br>
add_definitions(-DLLDB_USE_OS_LOG)<br>
endif()<br>
<br>
Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=355103&r1=355102&r2=355103&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=355103&r1=355102&r2=355103&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/cmake/modules/LLDBConfig.cmake (original)<br>
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake Thu Feb 28 08:04:54 2019<br>
@@ -1,4 +1,5 @@<br>
include(CheckCXXSymbolExists)<br>
+include(CheckTypeSize)<br>
<br>
set(LLDB_PROJECT_ROOT ${CMAKE_CURRENT_SOURCE_DIR})<br>
set(LLDB_SOURCE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/source")<br>
@@ -91,6 +92,29 @@ if (LLDB_DISABLE_CURSES)<br>
add_definitions( -DLLDB_DISABLE_CURSES )<br>
endif()<br>
<br>
+if (LLDB_DISABLE_LIBEDIT)<br>
+ add_definitions( -DLLDB_DISABLE_LIBEDIT )<br>
+else()<br>
+ find_package(LibEdit REQUIRED)<br>
+<br>
+ # Check if we libedit capable of handling wide characters (built with<br>
+ # '--enable-widec').<br>
+ set(CMAKE_REQUIRED_LIBRARIES ${libedit_LIBRARIES})<br>
+ set(CMAKE_REQUIRED_INCLUDES ${libedit_INCLUDE_DIRS})<br>
+ check_symbol_exists(el_winsertstr histedit.h LLDB_EDITLINE_USE_WCHAR)<br>
+ set(CMAKE_EXTRA_INCLUDE_FILES histedit.h)<br>
+ check_type_size(el_rfunc_t LLDB_EL_RFUNC_T_SIZE)<br>
+ if (LLDB_EL_RFUNC_T_SIZE STREQUAL "")<br>
+ set(LLDB_HAVE_EL_RFUNC_T 0)<br>
+ else()<br>
+ set(LLDB_HAVE_EL_RFUNC_T 1)<br>
+ endif()<br>
+ set(CMAKE_REQUIRED_LIBRARIES)<br>
+ set(CMAKE_REQUIRED_INCLUDES)<br>
+ set(CMAKE_EXTRA_INCLUDE_FILES)<br>
+endif()<br>
+<br>
+<br>
# On Windows, we can't use the normal FindPythonLibs module that comes with CMake,<br>
# for a number of reasons.<br>
# 1) Prior to MSVC 2015, it is only possible to embed Python if python itself was<br>
<br>
Modified: lldb/trunk/cmake/modules/LLDBGenerateConfig.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBGenerateConfig.cmake?rev=355103&r1=355102&r2=355103&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBGenerateConfig.cmake?rev=355103&r1=355102&r2=355103&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/cmake/modules/LLDBGenerateConfig.cmake (original)<br>
+++ lldb/trunk/cmake/modules/LLDBGenerateConfig.cmake Thu Feb 28 08:04:54 2019<br>
@@ -4,7 +4,6 @@ include(CheckSymbolExists)<br>
include(CheckIncludeFile)<br>
include(CheckIncludeFiles)<br>
include(CheckLibraryExists)<br>
-include(CheckTypeSize)<br>
<br>
set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)<br>
check_symbol_exists(ppoll poll.h HAVE_PPOLL)<br>
@@ -28,24 +27,6 @@ if(NOT UNIX)<br>
set(LLDB_DISABLE_POSIX 1)<br>
endif()<br>
<br>
-if (NOT LLDB_DISABLE_LIBEDIT)<br>
- # Check if we libedit capable of handling wide characters (built with<br>
- # '--enable-widec').<br>
- set(CMAKE_REQUIRED_LIBRARIES ${libedit_LIBRARIES})<br>
- set(CMAKE_REQUIRED_INCLUDES ${libedit_INCLUDE_DIRS})<br>
- check_symbol_exists(el_winsertstr histedit.h LLDB_EDITLINE_USE_WCHAR)<br>
- set(CMAKE_EXTRA_INCLUDE_FILES histedit.h)<br>
- check_type_size(el_rfunc_t LLDB_EL_RFUNC_T_SIZE)<br>
- if (LLDB_EL_RFUNC_T_SIZE STREQUAL "")<br>
- set(LLDB_HAVE_EL_RFUNC_T 0)<br>
- else()<br>
- set(LLDB_HAVE_EL_RFUNC_T 1)<br>
- endif()<br>
- set(CMAKE_REQUIRED_LIBRARIES)<br>
- set(CMAKE_REQUIRED_INCLUDES)<br>
- set(CMAKE_EXTRA_INCLUDE_FILES)<br>
-endif()<br>
-<br>
if(NOT LLDB_CONFIG_HEADER_INPUT)<br>
set(LLDB_CONFIG_HEADER_INPUT ${LLDB_INCLUDE_ROOT}/lldb/Host/Config.h.cmake)<br>
endif()<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>