<div dir="ltr"><div dir="ltr"><div dir="ltr">🎉🎉🎉</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 7, 2019 at 2:26 PM Frederic Riss via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: friss<br>
Date: Thu Mar  7 14:28:01 2019<br>
New Revision: 355647<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355647&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355647&view=rev</a><br>
Log:<br>
Add logging to TestQueues.py<br>
<br>
In an attempt to understand why the test is still failing after r355555,<br>
add some logging.<br>
<br>
Modified:<br>
    lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py?rev=355647&r1=355646&r2=355647&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py?rev=355647&r1=355646&r2=355647&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py Thu Mar  7 14:28:01 2019<br>
@@ -56,7 +56,23 @@ class TestQueues(TestBase):<br>
              expected_running,<br>
              (queue.GetNumRunningItems())))<br>
<br>
+    def describe_threads(self):<br>
+        desc = []<br>
+        for x in self.inferior_process:<br>
+            id = x.GetIndexID()<br>
+            reason_str = lldbutil.stop_reason_to_str(x.GetStopReason())<br>
+<br>
+            location = "\t".join([lldbutil.get_description(<br>
+                x.GetFrameAtIndex(i)) for i in range(x.GetNumFrames())])<br>
+            desc.append(<br>
+                "thread %d: %s at\n\t%s" %<br>
+                (id, reason_str, location))<br>
+        print('\n'.join(desc))<br>
+<br>
     def check_number_of_threads_owned_by_queue(self, queue, number_threads):<br>
+        if (queue.GetNumThreads() != number_threads):<br>
+            self.describe_threads()<br>
+<br>
         self.assertTrue(<br>
             queue.GetNumThreads() == number_threads,<br>
             "queue %s should have %d thread executing, but has %d" %<br>
@@ -125,6 +141,8 @@ class TestQueues(TestBase):<br>
         if len(threads) != 1:<br>
             self.fail("Failed to stop at breakpoint 1.")<br>
<br>
+        self.inferior_process = process<br>
+<br>
         queue_submittor_1 = lldb.SBQueue()<br>
         queue_performer_1 = lldb.SBQueue()<br>
         queue_performer_2 = lldb.SBQueue()<br>
@@ -291,6 +309,8 @@ class TestQueues(TestBase):<br>
         if len(threads) != 1:<br>
             self.fail("Failed to stop at breakpoint 1.")<br>
<br>
+        self.inferior_process = process<br>
+<br>
         libbtr_module_filespec = lldb.SBFileSpec("libBacktraceRecording.dylib")<br>
         libbtr_module = target.FindModule(libbtr_module_filespec)<br>
         if not libbtr_module.IsValid():<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>