<div dir="ltr"><div dir="ltr">Done in r354487. Thanks for the heads up!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 20, 2019 at 9:41 AM Jonas Devlieghere <<a href="mailto:jonas@devlieghere.com">jonas@devlieghere.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Based on the decorators of the other modules test it looks like this should be Darwin only. I'll update the test. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 20, 2019 at 9:31 AM Jan Kratochvil <<a href="mailto:jan.kratochvil@redhat.com" target="_blank">jan.kratochvil@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Wed, 20 Feb 2019 02:49:16 +0100, Jonas Devlieghere via lldb-commits wrote:<br>
> Author: jdevlieghere<br>
> Date: Tue Feb 19 17:49:16 2019<br>
> New Revision: 354425<br>
...<br>
> --- lldb/trunk/lit/Reproducer/Modules/TestModuleCXX.test (original)<br>
> +++ lldb/trunk/lit/Reproducer/Modules/TestModuleCXX.test Tue Feb 19 17:49:16 2019<br>
> @@ -1,4 +1,4 @@<br>
> -# REQUIRES: nowindows<br>
> +# UNSUPPORTED: system-windows<br>
<br>
It has started failing on Linux (Fedora 29 x86_64).  Is it expected?<br>
I haven't tried to debug it yet.<br>
<br>
<br>
Jan<br>
<br>
<br>
------------------------------------------------------------------------------<br>
[bash]jkratoch@host1.jankratochvil.net:/home/jkratoch/redhat/llvm-monorepo-clang# ./bin/llvm-lit -sv tools/lldb/lit --filter TestModuleCXX;echo $?<br>
llvm-lit: /home/jkratoch/redhat/llvm-monorepo/llvm/utils/lit/lit/llvm/config.py:337: note: using clang: /home/jkratoch/redhat/llvm-monorepo-clang/bin/clang<br>
llvm-lit: /home/jkratoch/redhat/llvm-monorepo/llvm/utils/lit/lit/llvm/config.py:337: note: using ld.lld: /home/jkratoch/redhat/llvm-monorepo-clang/bin/ld.lld<br>
llvm-lit: /home/jkratoch/redhat/llvm-monorepo/llvm/utils/lit/lit/llvm/config.py:337: note: using lld-link: /home/jkratoch/redhat/llvm-monorepo-clang/bin/lld-link<br>
llvm-lit: /home/jkratoch/redhat/llvm-monorepo/llvm/utils/lit/lit/llvm/config.py:337: note: using ld64.lld: /home/jkratoch/redhat/llvm-monorepo-clang/bin/ld64.lld<br>
llvm-lit: /home/jkratoch/redhat/llvm-monorepo/llvm/utils/lit/lit/llvm/config.py:337: note: using wasm-ld: /home/jkratoch/redhat/llvm-monorepo-clang/bin/wasm-ld<br>
FAIL: LLDB :: Reproducer/Modules/TestModuleCXX.test (1 of 1)<br>
******************** TEST 'LLDB :: Reproducer/Modules/TestModuleCXX.test' FAILED ********************<br>
Script:<br>
--<br>
: 'RUN: at line 4';   rm -rf /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 5';   rm -rf /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.clang-cache<br>
: 'RUN: at line 6';   rm -rf /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache<br>
: 'RUN: at line 9';   mkdir -p /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 10';   mkdir -p /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.clang-cache<br>
: 'RUN: at line 11';   mkdir -p /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache<br>
: 'RUN: at line 12';   cp /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/main.cpp /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 13';   cp /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/Foo.h /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 14';   cp /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/Bar.h /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 15';   cp /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/module.modulemap /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 18';   /home/jkratoch/redhat/llvm-monorepo-clang/bin/clang -pthread /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/main.cpp -g -fmodules -fcxx-modules -fmodules-cache-path=/home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.clang-cache -o /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out<br>
: 'RUN: at line 21';   /home/jkratoch/redhat/llvm-monorepo-clang/bin/lldb --no-lldbinit -S /home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init -x -b -o 'settings set symbols.clang-modules-cache-path /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache' -s /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/ModuleCXX.in --capture /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.repro /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out | /home/jkratoch/redhat/llvm-monorepo-clang/bin/FileCheck /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/TestModuleCXX.test --check-prefix CAPTURE<br>
: 'RUN: at line 24';   cat /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.repro/files.yaml | /home/jkratoch/redhat/llvm-monorepo-clang/bin/FileCheck /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/TestModuleCXX.test --check-prefix YAML<br>
: 'RUN: at line 30';   rm -rf /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root<br>
: 'RUN: at line 31';   rm -rf /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.clang-cache<br>
: 'RUN: at line 32';   rm -rf /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache<br>
: 'RUN: at line 35';   /home/jkratoch/redhat/llvm-monorepo-clang/bin/lldb --no-lldbinit -S /home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init -x -b -o 'settings set symbols.clang-modules-cache-path /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache' -s /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/ModuleCXX.in --replay /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.repro /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out | /home/jkratoch/redhat/llvm-monorepo-clang/bin/FileCheck /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/TestModuleCXX.test --check-prefix REPLAY<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
error: use of undeclared identifier 'Bar'<br>
/home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/TestModuleCXX.test:22:12: error: CAPTURE: expected string not found in input<br>
# CAPTURE: (success = 0)<br>
           ^<br>
<stdin>:1:1: note: scanning from here<br>
(lldb) command source -s 0 '/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'<br>
^<br>
<stdin>:12:54: note: possible intended match here<br>
Breakpoint 1: where = a.out`main + 22 at main.cpp:7:3, address = 0x0000000000401136<br>
------------------------------------------------------------------------------<br>
/home/jkratoch/redhat/llvm-monorepo-clang/bin/lldb --no-lldbinit -S /home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init -x -b -o 'settings set symbols.clang-modules-cache-path /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache' -s /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/ModuleCXX.in --capture /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.repro /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out<br>
(lldb) command source -s 0 '/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'<br>
Executing commands in '/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'.<br>
(lldb) # LLDB init file for the LIT tests.<br>
(lldb) settings set symbols.enable-external-lookup false<br>
(lldb) settings set interpreter.echo-comment-commands false<br>
(lldb) target create "/home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out"<br>
Current executable set to '/home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out' (x86_64).<br>
(lldb) settings set symbols.clang-modules-cache-path /home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.lldb-cache<br>
(lldb) command source -s 0 '/home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/ModuleCXX.in'<br>
Executing commands in '/home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Modules/Inputs/ModuleCXX.in'.<br>
(lldb) breakpoint set -f main.cpp -l 5<br>
Breakpoint 1: where = a.out`main + 22 at main.cpp:7:3, address = 0x0000000000401136<br>
(lldb) run<br>
Process 3900743 stopped<br>
* thread #1, name = 'a.out', stop reason = breakpoint 1.1<br>
    frame #0: 0x0000000000401136 a.out`main(argc=1, argv=0x00007fffffffcc78) at main.cpp:7:3<br>
   4<br>
   5    int main(int argc, char **argv) {<br>
   6      Foo foo;<br>
-> 7      stop(); // break here.<br>
   8      return 0;<br>
   9    }<br>
<br>
Process 3900743 launched: '/home/jkratoch/redhat/llvm-monorepo-clang/tools/lldb/lit/Reproducer/Modules/Output/TestModuleCXX.test.tmp.root/a.out' (x86_64)<br>
(lldb) expr -l Objective-C++ -- @import Foo<br>
(lldb) expr -l Objective-C++ -- @import Bar<br>
(lldb) expr -- Bar()<br>
error: use of undeclared identifier 'Bar'<br>
------------------------------------------------------------------------------<br>
</blockquote></div>
</blockquote></div>