<div dir="ltr">Might be better to only define the variable if HAVE_LIBCOMPRESSION is defined?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 9, 2019 at 8:58 AM Raphael Isemann via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was not accepted when it landed; it landed in state "Needs Review".<br>
This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL350675: Fix unused private field warning. (authored by teemperor, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D56458?vs=180748&id=180750#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56458?vs=180748&id=180750#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D56458/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56458/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D56458" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56458</a><br>
<br>
Files:<br>
  lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
<br>
<br>
Index: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
===================================================================<br>
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
@@ -69,8 +69,9 @@<br>
       m_echo_number(0), m_supports_qEcho(eLazyBoolCalculate), m_history(512),<br>
       m_send_acks(true), m_compression_type(CompressionType::None),<br>
       m_listen_url(), m_decompression_scratch_type(CompressionType::None),<br>
-      m_decompression_scratch(nullptr)<br>
-{ <br>
+      m_decompression_scratch(nullptr) {<br>
+  // Unused unless HAVE_LIBCOMPRESSION is defined.<br>
+  (void)m_decompression_scratch_type;<br>
 }<br>
<br>
 //----------------------------------------------------------------------<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>