<div dir="ltr">Very excited to see this.  I'm technically on vacation so I might not be able to review it immediately, but I'm looking forward to getting to it soon.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 2, 2019 at 4:36 PM Aaron Smith via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">asmith created this revision.<br>
asmith added reviewers: zturner, llvm-commits.<br>
Herald added subscribers: lldb-commits, abidh, mgorny, srhines.<br>
<br>
This is intended as a first step to make lldb-server work on Windows. Follow-up changes to implement remote capabilities in PlatformWindows, launch gdbserver, launch/attach processes using Windows APIs etc will come in separate revisions.<br>
<br>
The changes in this commit include the following:<br>
<br>
- #ifdef what's not supported on Windows, for example signals<br>
- Add a dummy 'waitpid' to the Windows PosixApi along with some definitions that are needed for compilation.<br>
- Setup WSAsocket connection in SystemInitializerLLGS::Initialize.<br>
- Add a namespace to static function 'terminate()' in lldb-server.cpp because its ambiguous with a Windows API.<br>
- Better error handling in SocketAddress::GetAddressInfo.<br>
- Clear the string before calling llvm::convertWideToUTF8 to avoid an unexpected assertion.<br>
<br>
<br>
Repository:<br>
  rLLDB LLDB<br>
<br>
<a href="https://reviews.llvm.org/D56233" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56233</a><br>
<br>
Files:<br>
  cmake/modules/LLDBConfig.cmake<br>
  include/lldb/Host/windows/PosixApi.h<br>
  include/lldb/Target/Platform.h<br>
  source/Host/common/SocketAddress.cpp<br>
  source/Host/windows/HostInfoWindows.cpp<br>
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
  tools/lldb-server/SystemInitializerLLGS.cpp<br>
  tools/lldb-server/lldb-gdbserver.cpp<br>
  tools/lldb-server/lldb-platform.cpp<br>
  tools/lldb-server/lldb-server.cpp<br>
<br>
</blockquote></div>