<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 10, 2018, at 11:23 AM, Leonard Mosescu <<a href="mailto:mosescu@google.com" class="">mosescu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">> BTW: check my changes in: <a href="https://reviews.llvm.org/D55522" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D55522</a><br class="">> It will be interesting to you since it parses the linux maps info if it is available in breakpad generated minidump files. This will give us enough info to create correct sections for object files when we have no ELF file or no symbol file (ELF/DWARF or breakpad). <br class=""><div class=""><br class=""></div><div class="">Looks interesting, thanks for pointing it out. From a quick glance it seems that your change would complement the generic support I'm adding here.</div></div></div></blockquote><br class="">Indeed it will. Part of my patch was a hook in the placeholder module GetObjectFile() where if someone set the symbol file for it via "target symbol add ..." it would replace the "m_file" in the module with the symbol file and then get the object file from the symbol file that was added.</div><div><br class=""></div><div>So it is a different approach to yours. I will attach my copy of "PlaceholderModule" to your patch so you can see what I did.</div><br class=""></body></html>