<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">I reverted it. Thanks.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>From:</b> Aleksandr Urakov <aleksandr.urakov@jetbrains.com>
<br>
<b>Sent:</b> Friday, November 30, 2018 9:25 AM<br>
<b>To:</b> reviews+D53759+public+b214dcdd73261027@reviews.llvm.org<br>
<b>Cc:</b> Zachary Turner <zturner@google.com>; aaron.lee.smith <aaron.lee.smith@gmail.com>; Stella Stamenova <stilis@microsoft.com>; llvm-commits@lists.llvm.org; pavel@labath.sk; 15dacaoyuan@gmail.com; aprantl@apple.com; jdevlieghere@apple.com; teemperor@gmail.com;
lldb-commits@lists.llvm.org; sanimir@subpath.org; chirag@raincode.com; b.gianfo@gmail.com<br>
<b>Subject:</b> Re: [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">I'm already OOO today, feel free to revert it.<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Am Fr., 30. Nov. 2018, 20:15 hat Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> geschrieben:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">stella.stamenova added a comment.<br>
<br>
It looks like after this change went in, the tests on Windows starting timing out instead of completing. The last run before the change took about 2 minutes and starting with the first run with this change, they're running for 40 minutes before being killed:<br>
<br>
After:<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8014%2Fbuilders%2Flldb-x64-windows-ninja%2Fbuilds%2F1774&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351801306&sdata=w0HJyE7Tqbd84qnmwtEnPbqSMGehVN3TqdiZVnAgGig%3D&reserved=0" target="_blank">http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1774</a><br>
<br>
Before:<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8014%2Fbuilders%2Flldb-x64-windows-ninja%2Fbuilds%2F1773&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351801306&sdata=T3mIA7QHgr89xwpOa8omn2SRGsVSlDPdorRbXn61Q4U%3D&reserved=0" target="_blank">http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1773</a><br>
<br>
Can you fix this today or pull the change out?<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD53759%2Fnew%2F&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351811315&sdata=juwD4303lDo%2Bu%2BQQ1N5vAZ8%2FsnsmNv7bC9QnP6ukY8U%3D&reserved=0" target="_blank">https://reviews.llvm.org/D53759/new/</a><br>
<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD53759&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351811315&sdata=%2BLb60xqfhy8xBYqi0%2FFXMpZgtQQ7FY4h%2BQrCW3evCU4%3D&reserved=0" target="_blank">https://reviews.llvm.org/D53759</a><br>
<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>