I’m ooo for at least 2 hours. Is it a test failure or a compilation failure?<br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 8, 2018 at 12:56 PM Davide Italiano <<a href="mailto:dccitaliano@gmail.com">dccitaliano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Zach, either this or your previous commit broke MacOS.<br>
Can you please take a look?<br>
Feel free to ping me (here or on IRC) if you need any help.<br>
<br>
<a href="http://green.lab.llvm.org/green/job/lldb-cmake/12343/" rel="noreferrer" target="_blank">http://green.lab.llvm.org/green/job/lldb-cmake/12343/</a><br>
<br>
--<br>
Davide<br>
On Thu, Nov 8, 2018 at 10:52 AM Zachary Turner via lldb-commits<br>
<<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: zturner<br>
> Date: Thu Nov 8 10:50:31 2018<br>
> New Revision: 346430<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=346430&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=346430&view=rev</a><br>
> Log:<br>
> Fix bug in PE/COFF plugin and ValueObjectVariable.<br>
><br>
> There are two bugs here. The first is that MSVC and clang-cl<br>
> emit their bss section under the name '.data' instead of '.bss'<br>
> but with the size and file offset set to 0. ObjectFilePECOFF<br>
> didn't handle this, and would only recognize a section as bss<br>
> if it was actually called '.bss'. The effect of this is that<br>
> if we tried to print the value of a variable that lived in BSS<br>
> we would fail.<br>
><br>
> The second bug is that ValueObjectVariable was only returning<br>
> the forward type, which is insufficient to print the value of an<br>
> enum. So we bump this up to the layout type.<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D54241" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54241</a><br>
><br>
> Added:<br>
> lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit<br>
> lldb/trunk/lit/SymbolFile/NativePDB/globals-bss.cpp<br>
> Modified:<br>
> lldb/trunk/lit/SymbolFile/NativePDB/ast-reconstruction.cpp<br>
> lldb/trunk/source/Core/ValueObjectVariable.cpp<br>
> lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp<br>
><br>
> Added: lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit?rev=346430&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit?rev=346430&view=auto</a><br>
> ==============================================================================<br>
> --- lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit (added)<br>
> +++ lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit Thu Nov 8 10:50:31 2018<br>
> @@ -0,0 +1,3 @@<br>
> +target variable GlobalVariable<br>
> +<br>
> +quit<br>
><br>
> Modified: lldb/trunk/lit/SymbolFile/NativePDB/ast-reconstruction.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/NativePDB/ast-reconstruction.cpp?rev=346430&r1=346429&r2=346430&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/NativePDB/ast-reconstruction.cpp?rev=346430&r1=346429&r2=346430&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/lit/SymbolFile/NativePDB/ast-reconstruction.cpp (original)<br>
> +++ lldb/trunk/lit/SymbolFile/NativePDB/ast-reconstruction.cpp Thu Nov 8 10:50:31 2018<br>
> @@ -89,22 +89,23 @@ Anonymous<A::B::C<int>>::D AnonABCVoidD;<br>
> // CHECK: (TrivialC) TC = {}<br>
> // CHECK: (TrivialS) TS = {}<br>
> // CHECK: (TrivialU) TU = {}<br>
> -// CHECK: (TrivialE) TE = <Unable to determine byte size.><br>
> -// CHECK: (A::B::C<int>) ABCInt = (ABCMember = <read memory from {{.*}} failed>)<br>
> -// CHECK: (A::B::C<float>) ABCFloat = (ABCMember = <read memory from {{.*}} failed>)<br>
> -// CHECK: (A::B::C<void>) ABCVoid = (ABCSpecializationMember = <read memory from {{.*}} failed>)<br>
> +// CHECK: (TrivialE) TE = TE_A<br>
> +// CHECK: (A::B::C<int>) ABCInt = (ABCMember = 0)<br>
> +// CHECK: (A::B::C<float>) ABCFloat = (ABCMember = 0)<br>
> +// CHECK: (A::B::C<void>) ABCVoid = (ABCSpecializationMember = 0x0000000000000000)<br>
> // CHECK: (A::C<0>) AC0 = {}<br>
> // CHECK: (A::C<-1>) ACNeg1 = {}<br>
> -// CHECK: (A::C<0>::D) AC0D = (ACDMember = <read memory from {{.*}} failed>, CPtr = <read memory from {{.*}} failed>)<br>
> -// CHECK: (A::C<-1>::D) ACNeg1D = (ACDMember = <read memory from {{.*}} failed>, CPtr = <read memory from {{.*}} failed>)<br>
> +// CHECK: (A::C<0>::D) AC0D = (ACDMember = 0, CPtr = 0x0000000000000000)<br>
> +// CHECK: (A::C<-1>::D) ACNeg1D = (ACDMember = 0, CPtr = 0x0000000000000000)<br>
> // CHECK: (A::D) AD = {}<br>
> -// CHECK: (A::D::E) ADE = (ADDMember = <read memory from {{.*}} failed>)<br>
> +// CHECK: (A::D::E) ADE = (ADDMember = 0)<br>
> // CHECK: Dumping clang ast for 1 modules.<br>
> // CHECK: TranslationUnitDecl {{.*}}<br>
> // CHECK: |-CXXRecordDecl {{.*}} class TrivialC definition<br>
> // CHECK: |-CXXRecordDecl {{.*}} struct TrivialS definition<br>
> // CHECK: |-CXXRecordDecl {{.*}} union TrivialU definition<br>
> // CHECK: |-EnumDecl {{.*}} TrivialE<br>
> +// CHECK: | `-EnumConstantDecl {{.*}} TE_A 'int'<br>
> // CHECK: |-NamespaceDecl {{.*}} A<br>
> // CHECK: | |-NamespaceDecl {{.*}} B<br>
> // CHECK: | | |-CXXRecordDecl {{.*}} struct C<int> definition<br>
><br>
> Added: lldb/trunk/lit/SymbolFile/NativePDB/globals-bss.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/NativePDB/globals-bss.cpp?rev=346430&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/NativePDB/globals-bss.cpp?rev=346430&view=auto</a><br>
> ==============================================================================<br>
> --- lldb/trunk/lit/SymbolFile/NativePDB/globals-bss.cpp (added)<br>
> +++ lldb/trunk/lit/SymbolFile/NativePDB/globals-bss.cpp Thu Nov 8 10:50:31 2018<br>
> @@ -0,0 +1,35 @@<br>
> +// clang-format off<br>
> +// REQUIRES: lld<br>
> +<br>
> +// Make sure we can read variables from BSS<br>
> +// RUN: clang-cl /Z7 /GS- /GR- /c /Fo%t.obj -- %s<br>
> +// RUN: lld-link /DEBUG /nodefaultlib /entry:main /OUT:%t.exe /PDB:%t.pdb -- %t.obj<br>
> +// RUN: llvm-readobj -s %t.exe | FileCheck --check-prefix=BSS %s<br>
> +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 lldb -f %t.exe -s \<br>
> +// RUN: %p/Inputs/globals-bss.lldbinit 2>&1 | FileCheck %s<br>
> +<br>
> +int GlobalVariable = 0;<br>
> +<br>
> +int main(int argc, char **argv) {<br>
> + return 0;<br>
> +}<br>
> +<br>
> +// BSS: Section {<br>
> +// BSS: Number: 3<br>
> +// BSS: Name: .data<br>
> +// BSS-NEXT: VirtualSize: 0x4<br>
> +// BSS-NEXT: VirtualAddress:<br>
> +// BSS-NEXT: RawDataSize: 0<br>
> +// BSS-NEXT: PointerToRawData: 0x0<br>
> +// BSS-NEXT: PointerToRelocations: 0x0<br>
> +// BSS-NEXT: PointerToLineNumbers: 0x0<br>
> +// BSS-NEXT: RelocationCount: 0<br>
> +// BSS-NEXT: LineNumberCount: 0<br>
> +// BSS-NEXT: Characteristics [ (0xC0000040)<br>
> +// BSS-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA (0x40)<br>
> +// BSS-NEXT: IMAGE_SCN_MEM_READ (0x40000000)<br>
> +// BSS-NEXT: IMAGE_SCN_MEM_WRITE (0x80000000)<br>
> +// BSS-NEXT: ]<br>
> +// BSS-NEXT: }<br>
> +<br>
> +// CHECK: (int) GlobalVariable = 0<br>
><br>
> Modified: lldb/trunk/source/Core/ValueObjectVariable.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectVariable.cpp?rev=346430&r1=346429&r2=346430&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectVariable.cpp?rev=346430&r1=346429&r2=346430&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/source/Core/ValueObjectVariable.cpp (original)<br>
> +++ lldb/trunk/source/Core/ValueObjectVariable.cpp Thu Nov 8 10:50:31 2018<br>
> @@ -66,9 +66,16 @@ ValueObjectVariable::~ValueObjectVariabl<br>
><br>
> CompilerType ValueObjectVariable::GetCompilerTypeImpl() {<br>
> Type *var_type = m_variable_sp->GetType();<br>
> - if (var_type)<br>
> - return var_type->GetForwardCompilerType();<br>
> - return CompilerType();<br>
> + if (!var_type)<br>
> + return CompilerType();<br>
> +<br>
> + // It's important to return the layout type here. If we have an enum then the<br>
> + // symbol file plugin may have decided to complete it lazily, in which case a<br>
> + // forward type won't be sufficient to display the variable. On the other<br>
> + // hand, if we have a pointer to a class type, then getting the full type will<br>
> + // resolve the class type, which is too much. The layout type is both<br>
> + // necessary and sufficient.<br>
> + return var_type->GetLayoutCompilerType();<br>
> }<br>
><br>
> ConstString ValueObjectVariable::GetTypeName() {<br>
><br>
> Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp?rev=346430&r1=346429&r2=346430&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp?rev=346430&r1=346429&r2=346430&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (original)<br>
> +++ lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Thu Nov 8 10:50:31 2018<br>
> @@ -710,7 +710,10 @@ void ObjectFilePECOFF::CreateSections(Se<br>
> llvm::COFF::IMAGE_SCN_CNT_INITIALIZED_DATA &&<br>
> ((const_sect_name == g_data_sect_name) ||<br>
> (const_sect_name == g_DATA_sect_name))) {<br>
> - section_type = eSectionTypeData;<br>
> + if (m_sect_headers[idx].size == 0 && m_sect_headers[idx].offset == 0)<br>
> + section_type = eSectionTypeZeroFill;<br>
> + else<br>
> + section_type = eSectionTypeData;<br>
> } else if (m_sect_headers[idx].flags &<br>
> llvm::COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA &&<br>
> ((const_sect_name == g_bss_sect_name) ||<br>
> @@ -1053,6 +1056,7 @@ ObjectFile::Type ObjectFilePECOFF::Calcu<br>
> }<br>
><br>
> ObjectFile::Strata ObjectFilePECOFF::CalculateStrata() { return eStrataUser; }<br>
> +<br>
> //------------------------------------------------------------------<br>
> // PluginInterface protocol<br>
> //------------------------------------------------------------------<br>
><br>
><br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>