<div dir="ltr"><div>I will update the master tonight.</div><div><br></div><div>Thanks</div><div><br></div><div>Galina<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 12, 2018 at 12:36 PM Stella Stamenova <<a href="mailto:stilis@microsoft.com">stilis@microsoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-6657412154454767877WordSection1">
<p class="MsoNormal">+ Galina,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Galina, is there anything we need to do for the buildbots to pick up the change that Vedant made?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">-Stella<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> <a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a> <<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>> <br>
<b>Sent:</b> Friday, October 12, 2018 12:34 PM<br>
<b>To:</b> Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank">stilis@microsoft.com</a>><br>
<b>Cc:</b> Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>>; <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>; <a href="mailto:reviews%2BD53175%2Bpublic%2B09519a8f992e0e1a@reviews.llvm.org" target="_blank">reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org</a><br>
<b>Subject:</b> Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Ah gotcha. For the public Darwin bots, we needed to specifically trigger a Jenkins job to distribute Zorg updates to all our builders. This can be a bit of a manual process, because you need to kill the jobs on the builders’ queues to make
sure they run the Zorg_Distribute job asap.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I’m not sure whether the Linux CI has a similar mechanism.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">vedant<u></u><u></u></p>
<div>
<p class="MsoNormal"><br>
<br>
<u></u><u></u></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Oct 12, 2018, at 12:31 PM, Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank">stilis@microsoft.com</a>> wrote:<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">Thanks, I’ve been monitoring the bots also and it looks like they haven’t picked up the zorg change yet. I don’t know if that’s supposed to just happen or if there’s something that needs to be done or if there’s a schedule for when they
update.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">-Stella<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<p class="MsoNormal"><b>From:</b><span class="m_-6657412154454767877apple-converted-space"> </span><a href="mailto:vsk@apple.com" target="_blank"><span style="color:purple">vsk@apple.com</span></a><span class="m_-6657412154454767877apple-converted-space"> </span><<a href="mailto:vsk@apple.com" target="_blank"><span style="color:purple">vsk@apple.com</span></a>><span class="m_-6657412154454767877apple-converted-space"> </span><br>
<b>Sent:</b><span class="m_-6657412154454767877apple-converted-space"> </span>Friday, October 12, 2018 11:33 AM<br>
<b>To:</b><span class="m_-6657412154454767877apple-converted-space"> </span>Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank"><span style="color:purple">stilis@microsoft.com</span></a>><br>
<b>Cc:</b><span class="m_-6657412154454767877apple-converted-space"> </span>Zachary Turner <<a href="mailto:zturner@google.com" target="_blank"><span style="color:purple">zturner@google.com</span></a>>;<span class="m_-6657412154454767877apple-converted-space"> </span><a href="mailto:lldb-commits@lists.llvm.org" target="_blank"><span style="color:purple">lldb-commits@lists.llvm.org</span></a>;<span class="m_-6657412154454767877apple-converted-space"> </span><a href="mailto:reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org" target="_blank"><span style="color:purple">reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org</span></a><br>
<b>Subject:</b><span class="m_-6657412154454767877apple-converted-space"> </span>Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<u></u><u></u></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">All right, Committed r344396, I’ll keep an eye out for failures.<u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">vedant<u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal"><br>
<br>
<br>
<u></u><u></u></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal">On Oct 12, 2018, at 9:58 AM, Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank"><span style="color:purple">stilis@microsoft.com</span></a>> wrote:<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">Those changes look reasonable, but I don't know how to test it either. I would be in favor of checking it in because the buildbots are currently broken and this can't make
it worse, right?<br>
<br>
-----Original Message-----<br>
From:<span class="m_-6657412154454767877apple-converted-space"> </span></span><a href="mailto:vsk@apple.com" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">vsk@apple.com</span></a><span class="m_-6657412154454767877apple-converted-space"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"> </span></span><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"><</span><a href="mailto:vsk@apple.com" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">vsk@apple.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">><span class="m_-6657412154454767877apple-converted-space"> </span><br>
Sent: Thursday, October 11, 2018 3:56 PM<br>
To: Stella Stamenova <</span><a href="mailto:stilis@microsoft.com" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">stilis@microsoft.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">><br>
Cc: Zachary Turner <</span><a href="mailto:zturner@google.com" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">zturner@google.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">>;<span class="m_-6657412154454767877apple-converted-space"> </span></span><a href="mailto:lldb-commits@lists.llvm.org" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">lldb-commits@lists.llvm.org</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">;<span class="m_-6657412154454767877apple-converted-space"> </span></span><a href="mailto:reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"><br>
Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<br>
<br>
Does this look reasonable to you? I'm not sure how to test this.<br>
<br>
diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py<br>
index 5a1b2e87..</span><a href="tel:62152924%20100644" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">62152924 100644</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"><br>
--- a/zorg/buildbot/builders/LLDBBuilder.py<br>
+++ b/zorg/buildbot/builders/LLDBBuilder.py<br>
@@ -270,6 +270,7 @@ def getLLDBTestSteps(f,<br>
compilerPath = compiler<br>
for arch in test_archs:<br>
DOTEST_OPTS=''.join(['--executable ' + bindir + '/lldb ',<br>
+ '--filecheck ' + bindir + '/FileCheck<span class="m_-6657412154454767877apple-converted-space"> </span><br>
+ ',<br>
'-A %s ' % arch,<br>
'-C %s ' % compilerPath,<br>
'-s lldb-test-traces-%s-%s ' % (compiler, arch), @@ -819,6 +820,7 @@ def getLLDBxcodebuildFactory(use_cc=None,<br>
workdir=lldb_srcdir))<br>
DOTEST_OPTS = ' '.join(['--executable',<br>
'%(lldb_bindir)s/lldb',<br>
+ '%(lldb_bindir)s/FileCheck',<br>
'--framework', '%(lldb_bindir)s/LLDB.framework',<br>
'-A', 'x86_64',<br>
'-C', 'clang',<br>
<br>
vedant<br>
<br>
<br>
<br>
</span><u></u><u></u></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">On Oct 11, 2018, at 3:46 PM, Stella Stamenova via Phabricator <</span><a href="mailto:reviews@reviews.llvm.org" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">reviews@reviews.llvm.org</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">>
wrote:<br>
<br>
stella.stamenova added a comment.<br>
<br>
The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode.<br>
<br>
I think the file that needs to be updated is:<br>
<br>
zorg\buildbot\builders\LLDBBuilder.py<br>
<br>
<br>
</span><a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"><br>
</span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fws.llvm.org%2F&data=02%7C01%7Cstilis%40microsoft.com%7Cc2dfa6c8f17d4b9ad94908d63079a814%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749696408731324&sdata=FXjVJDr2SMIBhhYbAThuMOaK4sEw29PnruvqTwvlozU%3D&reserved=0" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">ws.llvm.org</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">%2FD53175&data=02%7C01%7CSTILIS%</span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40microsoft.com%2F&data=02%7C01%7Cstilis%40microsoft.com%7Cc2dfa6c8f17d4b9ad94908d63079a814%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749696408731324&sdata=4NGt7TVttFXaIWRajl3xx7nTbsVGBG31R8oMBqJhoKs%3D&reserved=0" target="_blank"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:purple">40microsoft.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">%7Cb8693<br>
c9edfa5449d97db08d62fccaacd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0<br>
%7C636748953431151967&sdata=rdn7nntFECouzbw%2FPoQISVCGGrjLCqAygk8q<br>
l0St%2B5o%3D&reserved=0</span><u></u><u></u></p>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</blockquote></div>