<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Ah gotcha. For the public Darwin bots, we needed to specifically trigger a Jenkins job to distribute Zorg updates to all our builders. This can be a bit of a manual process, because you need to kill the jobs on the builders’ queues to make sure they run the Zorg_Distribute job asap.<div class=""><br class=""></div><div class="">I’m not sure whether the Linux CI has a similar mechanism.</div><div class=""><br class=""></div><div class="">vedant<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 12, 2018, at 12:31 PM, Stella Stamenova <<a href="mailto:stilis@microsoft.com" class="">stilis@microsoft.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Thanks, I’ve been monitoring the bots also and it looks like they haven’t picked up the zorg change yet. I don’t know if that’s supposed to just happen or if there’s something that needs to be done or if there’s a schedule for when they update.<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Thanks,<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">-Stella<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class="">From:</b><span class="Apple-converted-space"> </span><a href="mailto:vsk@apple.com" style="color: purple; text-decoration: underline;" class="">vsk@apple.com</a><span class="Apple-converted-space"> </span><<a href="mailto:vsk@apple.com" style="color: purple; text-decoration: underline;" class="">vsk@apple.com</a>><span class="Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Friday, October 12, 2018 11:33 AM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Stella Stamenova <<a href="mailto:stilis@microsoft.com" style="color: purple; text-decoration: underline;" class="">stilis@microsoft.com</a>><br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span>Zachary Turner <<a href="mailto:zturner@google.com" style="color: purple; text-decoration: underline;" class="">zturner@google.com</a>>;<span class="Apple-converted-space"> </span><a href="mailto:lldb-commits@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">lldb-commits@lists.llvm.org</a>;<span class="Apple-converted-space"> </span><a href="mailto:reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org" style="color: purple; text-decoration: underline;" class="">reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org</a><br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<o:p class=""></o:p></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">All right, Committed r344396, I’ll keep an eye out for failures.<o:p class=""></o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">vedant<o:p class=""></o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><br class=""><br class=""><o:p class=""></o:p></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">On Oct 12, 2018, at 9:58 AM, Stella Stamenova <<a href="mailto:stilis@microsoft.com" style="color: purple; text-decoration: underline;" class="">stilis@microsoft.com</a>> wrote:<o:p class=""></o:p></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">Those changes look reasonable, but I don't know how to test it either. I would be in favor of checking it in because the buildbots are currently broken and this can't make it worse, right?<br class=""><br class="">-----Original Message-----<br class="">From:<span class="apple-converted-space"> </span></span><a href="mailto:vsk@apple.com" style="color: purple; text-decoration: underline;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">vsk@apple.com</span></a><span class="apple-converted-space"><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class=""> </span></span><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class=""><</span><a href="mailto:vsk@apple.com" style="color: purple; text-decoration: underline;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">vsk@apple.com</span></a><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">><span class="apple-converted-space"> </span><br class="">Sent: Thursday, October 11, 2018 3:56 PM<br class="">To: Stella Stamenova <</span><a href="mailto:stilis@microsoft.com" style="color: purple; text-decoration: underline;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">stilis@microsoft.com</span></a><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">><br class="">Cc: Zachary Turner <</span><a href="mailto:zturner@google.com" style="color: purple; text-decoration: underline;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">zturner@google.com</span></a><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">>;<span class="apple-converted-space"> </span></span><a href="mailto:lldb-commits@lists.llvm.org" style="color: purple; text-decoration: underline;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">lldb-commits@lists.llvm.org</span></a><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">;<span class="apple-converted-space"> </span></span><a href="mailto:reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org" style="color: purple; text-decoration: underline;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org</span></a><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class=""><br class="">Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<br class=""><br class="">Does this look reasonable to you? I'm not sure how to test this.<br class=""><br class="">diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py<br class="">index 5a1b2e87..<a href="tel:62152924%20100644" style="color: purple; text-decoration: underline;" class="">62152924 100644</a><br class="">--- a/zorg/buildbot/builders/LLDBBuilder.py<br class="">+++ b/zorg/buildbot/builders/LLDBBuilder.py<br class="">@@ -270,6 +270,7 @@ def getLLDBTestSteps(f,<br class=""> compilerPath = compiler<br class=""> for arch in test_archs:<br class=""> DOTEST_OPTS=''.join(['--executable ' + bindir + '/lldb ',<br class="">+ '--filecheck ' + bindir + '/FileCheck<span class="apple-converted-space"> </span><br class="">+ ',<br class=""> '-A %s ' % arch,<br class=""> '-C %s ' % compilerPath,<br class=""> '-s lldb-test-traces-%s-%s ' % (compiler, arch), @@ -819,6 +820,7 @@ def getLLDBxcodebuildFactory(use_cc=None,<br class=""> workdir=lldb_srcdir))<br class=""> DOTEST_OPTS = ' '.join(['--executable',<br class=""> '%(lldb_bindir)s/lldb',<br class="">+ '%(lldb_bindir)s/FileCheck',<br class=""> '--framework', '%(lldb_bindir)s/LLDB.framework',<br class=""> '-A', 'x86_64',<br class=""> '-C', 'clang',<br class=""><br class="">vedant<br class=""><br style="caret-color: rgb(0, 0, 0); font-variant-caps: normal; text-align: start; -webkit-text-stroke-width: 0px; word-spacing: 0px;" class=""><br class=""></span><o:p class=""></o:p></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Helvetica, sans-serif;" class="">On Oct 11, 2018, at 3:46 PM, Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org" style="color: purple; text-decoration: underline;" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""><br class="">stella.stamenova added a comment.<br class=""><br class="">The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode.<br class=""><br class="">I think the file that needs to be updated is:<br class=""><br class="">zorg\buildbot\builders\LLDBBuilder.py<br class=""><br class=""><br class=""><a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie" style="color: purple; text-decoration: underline;" class="">https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie</a><br class=""><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fws.llvm.org%2F&data=02%7C01%7Cstilis%40microsoft.com%7C4ed280cd33e449b8d05708d630712aed%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749659954498980&sdata=dhL6bP%2BmjReY6WIzw4F8K8FXX0dIHB64cJv%2BykrOHDc%3D&reserved=0" style="color: purple; text-decoration: underline;" class="">ws.llvm.org</a>%2FD53175&data=02%7C01%7CSTILIS%<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40microsoft.com%2F&data=02%7C01%7Cstilis%40microsoft.com%7C4ed280cd33e449b8d05708d630712aed%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749659954498980&sdata=%2FnKkN0v3DrJ%2FW4CQv987wTURI%2BMoHptOEczJKuxbr6k%3D&reserved=0" style="color: purple; text-decoration: underline;" class="">40microsoft.com</a>%7Cb8693<br class="">c9edfa5449d97db08d62fccaacd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0<br class="">%7C636748953431151967&sdata=rdn7nntFECouzbw%2FPoQISVCGGrjLCqAygk8q<br class="">l0St%2B5o%3D&reserved=0</span></div></blockquote></div></blockquote></div></div></div></div></blockquote></div><br class=""></div></body></html>