<div dir="ltr">Just curious, what prompted this change? (compiler diagnostic? forcing value initialization in the member initializer list is harmless in this case)<div><br></div><div>Also, if we want to do this kind of cleanup, m_compiler initialization is also redundant.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 30, 2018 at 8:39 AM, Adrian Prantl via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Thu Aug 30 08:39:08 2018<br>
New Revision: 341080<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=341080&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=341080&view=rev</a><br>
Log:<br>
Remove redundant initialization<br>
<br>
Modified:<br>
    lldb/trunk/source/Plugins/<wbr>ExpressionParser/Clang/<wbr>ClangExpressionParser.cpp<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>ExpressionParser/Clang/<wbr>ClangExpressionParser.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=341080&r1=341079&r2=341080&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/ExpressionParser/<wbr>Clang/ClangExpressionParser.<wbr>cpp?rev=341080&r1=341079&r2=<wbr>341080&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>ExpressionParser/Clang/<wbr>ClangExpressionParser.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>ExpressionParser/Clang/<wbr>ClangExpressionParser.cpp Thu Aug 30 08:39:08 2018<br>
@@ -222,7 +222,7 @@ ClangExpressionParser::<wbr>ClangExpressionPa<br>
                                              Expression &expr,<br>
                                              bool generate_debug_info)<br>
     : ExpressionParser(exe_scope, expr, generate_debug_info), m_compiler(),<br>
-      m_code_generator(), m_pp_callbacks(nullptr) {<br>
+      m_pp_callbacks(nullptr) {<br>
   Log *log(lldb_private::<wbr>GetLogIfAllCategoriesSet(<wbr>LIBLLDB_LOG_EXPRESSIONS));<br>
<br>
   // We can't compile expressions without a target.  So if the exe_scope is<br>
<br>
<br>
______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>