<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 30, 2018, at 9:43 AM, Leonard Mosescu <<a href="mailto:mosescu@google.com" class="">mosescu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Just curious, what prompted this change? (compiler diagnostic? forcing value initialization in the member initializer list is harmless in this case)</div></div></blockquote><div><br class=""></div><div>This particular change was (for whatever reason) in the <a href="http://swift.org" class="">swift.org</a> branch of LLDB and I'm always trying to remove pointless differences between the two branches.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">Also, if we want to do this kind of cleanup, m_compiler initialization is also redundant.</div></div></div></blockquote><div><br class=""></div>That's a fair point!</div><div><br class=""></div><div>-- adrian</div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Aug 30, 2018 at 8:39 AM, Adrian Prantl via lldb-commits <span dir="ltr" class=""><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br class="">
Date: Thu Aug 30 08:39:08 2018<br class="">
New Revision: 341080<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=341080&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=341080&view=rev</a><br class="">
Log:<br class="">
Remove redundant initialization<br class="">
<br class="">
Modified:<br class="">
lldb/trunk/source/Plugins/<wbr class="">ExpressionParser/Clang/<wbr class="">ClangExpressionParser.cpp<br class="">
<br class="">
Modified: lldb/trunk/source/Plugins/<wbr class="">ExpressionParser/Clang/<wbr class="">ClangExpressionParser.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=341080&r1=341079&r2=341080&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/lldb/trunk/source/<wbr class="">Plugins/ExpressionParser/<wbr class="">Clang/ClangExpressionParser.<wbr class="">cpp?rev=341080&r1=341079&r2=<wbr class="">341080&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- lldb/trunk/source/Plugins/<wbr class="">ExpressionParser/Clang/<wbr class="">ClangExpressionParser.cpp (original)<br class="">
+++ lldb/trunk/source/Plugins/<wbr class="">ExpressionParser/Clang/<wbr class="">ClangExpressionParser.cpp Thu Aug 30 08:39:08 2018<br class="">
@@ -222,7 +222,7 @@ ClangExpressionParser::<wbr class="">ClangExpressionPa<br class="">
Expression &expr,<br class="">
bool generate_debug_info)<br class="">
: ExpressionParser(exe_scope, expr, generate_debug_info), m_compiler(),<br class="">
- m_code_generator(), m_pp_callbacks(nullptr) {<br class="">
+ m_pp_callbacks(nullptr) {<br class="">
Log *log(lldb_private::<wbr class="">GetLogIfAllCategoriesSet(<wbr class="">LIBLLDB_LOG_EXPRESSIONS));<br class="">
<br class="">
// We can't compile expressions without a target. So if the exe_scope is<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>