<div dir="ltr"><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial">The new test cases did catch a real bug:</div><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial"><br></div><blockquote style="font-size:small;text-decoration-style:initial;text-decoration-color:initial;margin:0px 0px 0px 40px;border:none;padding:0px"><div><div>[ RUN      ] VMRange.CollectionContains</div></div><div><div>llvm/src/tools/lldb/unittests/<wbr>Utility/VMRangeTest.cpp:146: Failure</div></div><div><div>Value of: VMRange::ContainsRange(<wbr>collection, VMRange(0x100, 0x104))</div></div><div><div>  Actual: false</div></div><div><div>Expected: true</div></div></blockquote><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial"><div style="color:rgb(0,0,0);font-family:"Droid Sans Mono",monospace,monospace,"Droid Sans Fallback";font-weight:normal;line-height:18px;white-space:pre-wrap"><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">  </span><span style="color:rgb(0,0,255)">class</span><span style="color:rgb(0,0,0)"> </span><span style="color:rgb(38,127,153)">RangeInRangeUnaryPredicate</span><span style="color:rgb(0,0,0)"> {</span></div><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">  </span><span style="color:rgb(0,0,255)">public:</span></div><div><span style="background-color:rgb(255,255,255);color:rgb(0,0,0)">    </span><span style="background-color:rgb(255,255,255);color:rgb(121,94,38)">RangeInRangeUnaryPredicate</span><span style="background-color:rgb(255,255,255);color:rgb(0,0,0)">(<wbr>VMRange range) : </span><span style="background-color:rgb(255,255,255);color:rgb(121,94,38)">_range</span><span style="color:rgb(0,0,0)"><span style="background-color:rgb(255,255,255)">(range) {} </span><span style="background-color:rgb(255,255,0)">// note that _range binds to a temporary!</span></span></div><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">    </span><span style="color:rgb(0,0,255)">bool</span><span style="color:rgb(0,0,0)"> </span><span style="color:rgb(175,0,219)">operator</span><span style="color:rgb(0,0,0)">()(</span><span style="color:rgb(0,0,255)">const</span><span style="color:rgb(0,0,0)"> VMRange </span><span style="color:rgb(0,0,0)">&</span><span style="color:rgb(0,0,0)">range) </span><span style="color:rgb(0,0,255)">const</span><span style="color:rgb(0,0,0)"> {</span></div><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">      </span><span style="color:rgb(175,0,219)">return</span><span style="color:rgb(0,0,0)"> range.</span><span style="color:rgb(121,94,38)">Contains</span><span style="color:rgb(0,0,0)">(_range);</span></div><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">    }</span></div><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">    </span><span style="color:rgb(0,0,255)">const</span><span style="color:rgb(0,0,0)"> VMRange </span><span style="color:rgb(0,0,0)">&</span><span style="color:rgb(0,0,0)">_range;</span></div><div style="background-color:rgb(255,255,255)"><span style="color:rgb(0,0,0)">  };</span></div></div><br></div>I just sent out a review for the fix (<a href="https://reviews.llvm.org/D50290">https://reviews.llvm.org/D50290</a>)<br class="gmail-Apple-interchange-newline"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 24, 2018 at 4:53 PM, Raphael Isemann via Phabricator via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was not accepted when it landed; it landed in state "Needs Review".<br>
This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL337873: Add unit tests for VMRange (authored by teemperor, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D49415?vs=157172&id=157173#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D49415?vs=157172&id=157173#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D49415" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D49415</a><br>
<br>
Files:<br>
  lldb/trunk/unittests/Utility/<wbr>CMakeLists.txt<br>
  lldb/trunk/unittests/Utility/<wbr>VMRangeTest.cpp<br>
<br>
<br>______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br></div>