<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 30, 2018, at 12:17 PM, Leonard Mosescu <<a href="mailto:mosescu@google.com" class="">mosescu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">FYI, Breakpad & Crashpad will start generating the Microsoft flavor of ARM minidumps soon.</div></div></blockquote><div><br class=""></div>How do we tell the difference? I am guessing the ProcessorArchitecture will both be set to "PROCESSOR_ARCHITECTURE_ARM". Are plug-ins expected to look at the byte size of the thread context then?</div><div><br class=""></div><div>Greg</div><div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Jul 25, 2018 at 9:44 AM, Leonard Mosescu via Phabricator <span dir="ltr" class=""><<a href="mailto:reviews@reviews.llvm.org" target="_blank" class="">reviews@reviews.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">lemo added inline comments.<br class="">
<br class="">
<br class="">
================<br class="">
Comment at: source/Plugins/Process/<wbr class="">minidump/<wbr class="">RegisterContextMinidump_ARM.<wbr class="">cpp:51<br class="">
+ reg_fpscr,<br class="">
+ reg_d0, reg_d1, reg_d2, reg_d3, reg_d4, reg_d5, reg_d6, reg_d7,<br class="">
+ reg_d8, reg_d9, reg_d10, reg_d11, reg_d12, reg_d13, reg_d14, reg_d15,<br class="">
----------------<br class="">
Pavel's comment reminded me: what about the S registers (32bit fp) and Q registers (128bit Neon)?<br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D49750" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D49750</a><br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>