<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">remove space before (</span><br></blockquote><div> </div>I'd be happy to make the change, but looking at the rest of the file it seems that almost everything uses the opposite convention: Foo (...). <div><br></div><div>So, to make sure I'm making the right change, is this how it should look?</div><div><br></div><div><div> lldb::SBProcess</div><div> LoadCore(const char *core_file);</div><div><br></div><div> lldb::SBProcess</div><div> LoadCore(const char *core_file, lldb::SBError &error);</div></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 11, 2018 at 1:47 PM, Greg Clayton via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">clayborg accepted this revision.<br>
clayborg added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
Remove extra spaces before ( and good to go.<br>
<br>
<br>
<br>
================<br>
Comment at: scripts/interface/SBTarget.i:<wbr>282<br>
lldb::SBProcess<br>
- LoadCore(const char *core_file);<br>
- <br>
+ LoadCore (const char *core_file);<br>
+<br>
----------------<br>
remove space before (<br>
<br>
<br>
================<br>
Comment at: scripts/interface/SBTarget.i:<wbr>285<br>
+ lldb::SBProcess<br>
+ LoadCore (const char *core_file, lldb::SBError &error);<br>
+<br>
----------------<br>
remove space before (<br>
<br>
<br>
================<br>
Comment at: scripts/interface/SBTarget.i:<wbr>288<br>
lldb::SBProcess<br>
Attach (lldb::SBAttachInfo &attach_info, lldb::SBError& error);<br>
<br>
----------------<br>
remove space before (<br>
<br>
<br>
<a href="https://reviews.llvm.org/D48049" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D48049</a><br>
<br>
<br>
<br>
</blockquote></div><br></div>