<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Can you help me understand why this dependency poses a problem? It's not clear to me how to resolve this otherwise. The point of the patch is to ask the clang driver for the clang module cache path. If the problem is that we otherwise don't use the driver and now pull it in, would moving the Clang API into a different clang library work? Which one?<div class=""><br class=""></div><div class="">-- adrian<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 22, 2018, at 11:28 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">This change has introduced a dependency from Core -> clang Driver (due to #include "clang/Driver/Driver.h" in ModuleList.cpp). Can you please try to find a way to remove this dependency?<br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Mar 2, 2018 at 2:45 PM Phabricator via Phabricator via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was not accepted when it landed; it landed in state "Needs Review".<br class="">
This revision was automatically updated to reflect the committed changes.<br class="">
Closed by commit rL326628: Make the clang module cache setting available without a target (authored by adrian, committed by ).<br class="">
Herald added a subscriber: llvm-commits.<br class="">
<br class="">
Changed prior to commit:<br class="">
<a href="https://reviews.llvm.org/D43984?vs=136803&id=136858#toc" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D43984?vs=136803&id=136858#toc</a><br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://reviews.llvm.org/D43984" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D43984</a><br class="">
<br class="">
Files:<br class="">
lldb/trunk/include/lldb/Core/ModuleList.h<br class="">
lldb/trunk/include/lldb/Target/Target.h<br class="">
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/Makefile<br class="">
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py<br class="">
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/f.h<br class="">
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/main.m<br class="">
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/module.modulemap<br class="">
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py<br class="">
lldb/trunk/source/Core/Debugger.cpp<br class="">
lldb/trunk/source/Core/ModuleList.cpp<br class="">
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp<br class="">
lldb/trunk/source/Target/Target.cpp<br class="">
<br class="">
_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></div></body></html>