<div dir="ltr">This change has introduced a dependency from Core -> clang Driver (due to #include "clang/Driver/Driver.h" in ModuleList.cpp).  Can you please try to find a way to remove this dependency?<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 2, 2018 at 2:45 PM Phabricator via Phabricator via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was not accepted when it landed; it landed in state "Needs Review".<br>
This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL326628: Make the clang module cache setting available without a target (authored by adrian, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D43984?vs=136803&id=136858#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43984?vs=136803&id=136858#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D43984" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43984</a><br>
<br>
Files:<br>
  lldb/trunk/include/lldb/Core/ModuleList.h<br>
  lldb/trunk/include/lldb/Target/Target.h<br>
  lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/Makefile<br>
  lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py<br>
  lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/f.h<br>
  lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/main.m<br>
  lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/module.modulemap<br>
  lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py<br>
  lldb/trunk/source/Core/Debugger.cpp<br>
  lldb/trunk/source/Core/ModuleList.cpp<br>
  lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp<br>
  lldb/trunk/source/Target/Target.cpp<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div></div>